Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel lookup #475

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

davidbrochart
Copy link
Contributor

This should fix the errors in #473 (https://github.com/jupyter-server/jupyter_server/pull/473/checks?check_run_id=2323090792#step:14:342), but this is not addressing the real root cause.

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #475 (9fa0bbf) into master (02cc7d7) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   77.81%   77.71%   -0.10%     
==========================================
  Files         106      106              
  Lines        9136     9137       +1     
  Branches      979      979              
==========================================
- Hits         7109     7101       -8     
- Misses       1678     1687       +9     
  Partials      349      349              
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 77.60% <100.00%> (-3.02%) ⬇️
jupyter_server/services/kernels/handlers.py 58.24% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cc7d7...9fa0bbf. Read the comment docs.

@davidbrochart
Copy link
Contributor Author

davidbrochart commented Apr 12, 2021

Actually, it looks like the kernel was shut down (and thus removed from the connections) before we ask for the status in the front-end, so this change might be right.
Maybe this is because the new jupyter_client does things in a different order now that it's async?

@davidbrochart davidbrochart marked this pull request as ready for review April 12, 2021 14:23
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David. This change looks good.

Yes, with async we now get to deal with race conditions more frequently particularly between front-end and periodic callbacks (which triggered this one). (Ref: #472)

@kevin-bates kevin-bates merged commit 5dfdb1d into jupyter-server:master Apr 12, 2021
@davidbrochart davidbrochart deleted the fix_kernel_lookup branch April 12, 2021 15:03
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants