-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kernel lookup #475
Fix kernel lookup #475
Conversation
59a68ae
to
9fa0bbf
Compare
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 77.81% 77.71% -0.10%
==========================================
Files 106 106
Lines 9136 9137 +1
Branches 979 979
==========================================
- Hits 7109 7101 -8
- Misses 1678 1687 +9
Partials 349 349
Continue to review full report at Codecov.
|
Actually, it looks like the kernel was shut down (and thus removed from the connections) before we ask for the status in the front-end, so this change might be right. |
9fa0bbf
to
276762e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks David. This change looks good.
Yes, with async we now get to deal with race conditions more frequently particularly between front-end and periodic callbacks (which triggered this one). (Ref: #472)
…ookup Fix kernel lookup
This should fix the errors in #473 (https://github.com/jupyter-server/jupyter_server/pull/473/checks?check_run_id=2323090792#step:14:342), but this is not addressing the real root cause.