-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run_sync and ensure_async functions #315
Conversation
9ff8aed
to
39cfbff
Compare
Mind adding tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@meeseeksdev please backport to 4.x |
Oops, something went wrong applying the patch ... Please have a look at my logs. |
From the log, it is a merge conflict, but for some reason the bot didn't give the usual message:
|
I think @fcollonval was having issues with meeseeks lately too. |
(cherry picked from commit 51b8a12)
Small afer the fact question, why |
We just didn't face this situation, but I agree it would have been more generic. |
ensure_async
is used injupyter-client
,jupyter-server
andnbclient
.run_sync
is used injupyter-client
andnbclient
.See jupyter/nbclient#259.