Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nest-asyncio #259

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Conversation

davidbrochart
Copy link
Member

Experimenting with jupyter-client's run_sync which doesn't use nest-asyncio.

@davidbrochart
Copy link
Member Author

@blink1073 This seems to work well!
Do you think we should copy the code from jupyter-client, as it is done in this PR, or extract out jupyter-client's run_sync into a common library?

@davidbrochart
Copy link
Member Author

cc @maartenbreddels @SylvainCorlay

@blink1073
Copy link
Contributor

I'm hesitant to add a whole new library. Perhaps we could put the code in Jupyter Core 5.x and 4.x?

@davidbrochart
Copy link
Member Author

Definitely not a new library just for this. Actually, it may also be fine like that, even though there's a bit of code duplication.

@blink1073
Copy link
Contributor

blink1073 commented Nov 24, 2022

jupyter_client could use jupyter_core's implementation once it is there.

@davidbrochart
Copy link
Member Author

OK, I'll open PRs.

@blink1073
Copy link
Contributor

We should be able to use meeseeks to backport the PR from main.

@davidbrochart
Copy link
Member Author

This PR needs jupyter/jupyter_core#315.

@davidbrochart
Copy link
Member Author

b77eb06 reapplies #258, which was overridden by #257.

@blink1073
Copy link
Contributor

We shouldn't per-emptively add upper bounds to dependencies, see https://iscinumpy.dev/post/bound-version-constraints/

@davidbrochart
Copy link
Member Author

We shouldn't per-emptively add upper bounds to dependencies, see https://iscinumpy.dev/post/bound-version-constraints/

👍

@davidbrochart davidbrochart merged commit 168340e into jupyter:main Nov 29, 2022
@davidbrochart davidbrochart deleted the remove_nest_asyncio branch November 29, 2022 09:01
@blink1073 blink1073 mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants