-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nest-asyncio #259
Remove nest-asyncio #259
Conversation
af0d4bb
to
9b2a3a6
Compare
@blink1073 This seems to work well! |
I'm hesitant to add a whole new library. Perhaps we could put the code in Jupyter Core 5.x and 4.x? |
Definitely not a new library just for this. Actually, it may also be fine like that, even though there's a bit of code duplication. |
|
OK, I'll open PRs. |
We should be able to use meeseeks to backport the PR from main. |
3092f0c
to
fd66576
Compare
This PR needs jupyter/jupyter_core#315. |
fd66576
to
fbabb2b
Compare
We shouldn't per-emptively add upper bounds to dependencies, see https://iscinumpy.dev/post/bound-version-constraints/ |
👍 |
f8f5574
to
94a6b89
Compare
Experimenting with jupyter-client's run_sync which doesn't use
nest-asyncio
.