[MRG] Add Figshare to UI

[nuest]

! This depends on an unreleased version of repo2docker !

This closes #938.

But it's not ready yet :-) Just would like to get some feedback :-), and need help:

With the UI, I get a /master at the end of the URL that I don't want:

http://localhost:8585/v2/figshare/10.6084/m9.figshare.9782777.v1/master

Where does that get added? I can't find it :-/.

OTOH, the local test URL without /master

http://localhost:8585/v2/figshare/10.6084/m9.figshare.9782777.v2

gives me "Waiting for build to start" and in the logs there is just

[..]
[D 190912 13:05:18 build:94] 2 build pods
[D 190912 13:05:18 build:141] Build phase summary: {
     "Pending": 2
    }

For several minutes now... shouldn't there be more logs?

---

Related questions

• With

python3 -m pip install -e .
./testing/minikube/install-hub

I should have the latest code running in my local kube, right?

• Is it worth writing down in the docs all the places where something has to be added for a new provider? Though this list might be outdated with a new UI:
  • binderhub/main.py
    • SPEC_NAMES
    • from .repoproviders import
  • repo_providers = Dict(
  • binderhub/event-schemas/launch.json (though unsure what that is for)
  • binderhub/repoproviders.py the actual class FigshareProvider(RepoProvider):
  • binderhub/static/js/index.js the example text
  • binderhub/templates/index.html the item in the dropdown
• Have you considered generating some bits, e.g. build repro_providers at runtime by asking all the imported instances of RepoProvidder how they want to be added to that list ?
• Is it worth attempting to generate the UI parts from a service endpoint for the next ()?
• Is is possible to run the BinderHub outside of Kubernetes to debug the code?

[betatim]

To get the latest version (or a particular version) of repo2docker you need to specify it. The BinderHub uses (I think) the latest released version.

binderhub/binderhub/app.py

Lines 359 to 365 in 3fe8143

	build_image = Unicode(
	'jupyter/repo2docker:0.8.0',
	help="""
	The repo2docker image to be used for doing builds
	""",
	config=True
	)

to see the related traitlet code.

[betatim]

I think https://github.com/jupyterhub/binderhub/blob/master/binderhub/static/js/index.js#L109-L112 holds the secret to the mysterious trailing master. Did I mention there is "a bit of code duplication and having to change stuff in multiple places"? :-/

[nuest]

"Mysterious trailing master" removed, see also #953.

Works now locally for me, ready for review, though this relies on a new repo2docker version, so not sure what the process is then.

---

Regarding the build stuck at "Waiting for build to start...", the minikube dashboard shows me

The error message "Failed to pull image "jupyter-repo2docker:figshare": rpc error: code = Unknown desc = Error response from daemon: pull access denied for jupyter-repo2docker, repository does not exist or may require 'docker login'" helped me so far as to identify the issue a bit further:

• imagePullPolicy: IfNotPresent is configured in /binderhub/helm-chart/binderhub/templates/deployment.yaml
• there seems to be a problem with my local r2d image I want to use for testing
• solution: I have to build my repo2docker image using the Docker daemon of minikube

[betatim]

To get the tests to pass this needs rebasing onto the latest commit from master. Required git-fu:

git checkout master
git fetch upstream
git merge upstream/master
git checkout <thisbranch>
git rebase master
git push -f

[betatim]

nit: I'm not wild about having editor specific ignores. Mostly because I fear we end up with many many different (poorly maintained) ignores for all the different editors people use. I think it is nicer if each of us has their own "global" gitignore a la https://help.github.com/en/articles/ignoring-files#create-a-global-gitignore

[betatim]

I've rebased this on master, if the tests pass this can be merged.

[nuest]

You beat me to it!

[nuest]

🎆 🍾