-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding repoproviders documentation #1017
Conversation
and modifying a set of methods/attributes to interface with the online | ||
provider to which you are providing access. | ||
|
||
In order to extend the supported repository providers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a step that it is highly likely that your first step would be to add a new content provider to repo2docker?
Co-Authored-By: Tim Head <betatim@gmail.com>
accepted your comments and added a note about content providers. I also realized we don't have a similar section for how to add a new content provider in the repo2docker docs, so I opened jupyterhub/repo2docker#823 too |
9d1eeee
to
7a28771
Compare
Co-Authored-By: Tim Head <betatim@gmail.com>
I re-visited a repo provider I've added (see #951) and found that I had to make changes to [ The JS file reminds me of the need for a proper API to generate the UI... still very good to document the current state though! ] |
@nuest aren't both of those addressed here: https://github.com/jupyterhub/binderhub/pull/1017/files#diff-cbeb18fbf4548b84e49c010cf02f439dR57 ? Let me know if I'm missing something! (and I totally agree about the need to do less hard-coding etc) |
@choldgraf My bad, those files are indeed included in that changeset! |
I thought about it a bit more and decided to add repository provider information to the table, the new version is here: |
Merging this now. We can keep tweaking it in a new PR. |
This is a documentation update for repository providers, it does these main things:
provide guideance on PRs like Add Dataverse to UI. Fixes #900 #969
What do folks think?