Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding instructions for contentprovider extension #824

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Dec 4, 2019

This does two things:

  1. Adds some short instructions for extending repo2docker to a new ContentProvider
  2. Updates some of the section titles in this section in order to make the sidebar easier to parse (having the word "repo2docker" in each page title seemed redundant and cluttered the sidebar)

This is related to jupyterhub/binderhub#1017. Eventually the two docs should probably reference one another, as adding a new RepoProvider in BinderHub is often paired with adding a new ContentProvider in repo2docker. This also makes me wonder why it's called "RepoProvider" in one and "ContentProvider" in another...


This is a living document talking about the architecture of repo2docker
from various perspectives.

```eval_rst
.. _buildpacks:
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Is this a way to smuggle RST into an otherwise MD file?

@betatim
Copy link
Member

betatim commented Dec 5, 2019

Thanks for getting our documentation into shape. Feels like a "new years resolution to get stuff in order" spirit and it isn't even 2020 yet!

@betatim betatim merged commit f3a7e44 into jupyterhub:master Dec 5, 2019
markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
adding instructions for contentprovider extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants