Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random temporary file name for rserver secure cookie key #94

Closed
wants to merge 1 commit into from

Conversation

julozi
Copy link

@julozi julozi commented Aug 19, 2020

When using the batchspawner, we can have several rserver session started on the same cluster node. However, rserver is by default using the same path /tmp/rstudio-server/secure-cookie-key to store secure cookie key. As a result the cookie key file is locked and owned by the first user starting a RStudio session on a given node.
To avoid this, we need to define a distinct temporary file for rserver secure cookie key for each rserver instance.

@welcome
Copy link

welcome bot commented Aug 19, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ryanlovett
Copy link
Collaborator

This is great, thanks very much! One request: could you please omit prefix='/tmp/' ? That way we could let tempfile determine the directory. Or is /tmp a hard requirement for rstudio?

relevant #64

@danielfrg
Copy link
Contributor

I can confirm that this totally works on master and you don't need the prefix='/tmp'.

@julozi would you be able to update this branch to master? If not I can do it.

@ryanlovett
Copy link
Collaborator

Fixed by #98.

@ryanlovett ryanlovett closed this Nov 30, 2021
@julozi julozi deleted the cookie-file branch August 22, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants