Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmp file for secure cookie #98

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Use tmp file for secure cookie #98

merged 5 commits into from
Nov 12, 2021

Conversation

danielfrg
Copy link
Contributor

Updating #94 to master so we can get it merged.

This is needed to support multiple RStudio Sessions in the same machine.

The actual changes are very little there are other linting changes that happened automatically because of my VS Code setup, I can remove those if needed but hopefully its ok :D

The actual changes are:

def _get_cmd(port):
        ntf = tempfile.NamedTemporaryFile()
        cmd = [
            get_rstudio_executable("rserver"),
            "--auth-none=1",
            "--www-frame-origin=same",
            "--www-port=" + str(port),
            "--www-verify-user-agent=0",
            "--secure-cookie-key-file=" + ntf.name,
        ]

@welcome
Copy link

welcome bot commented Apr 14, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@danielfrg
Copy link
Contributor Author

I updated the branch to master. @ryanlovett would you be able to take a look at this?

@ryanlovett ryanlovett merged commit 80c1db1 into jupyterhub:master Nov 12, 2021
@welcome
Copy link

welcome bot commented Nov 12, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@ryanlovett
Copy link
Collaborator

Lgtm. Thanks for your patience @danielfrg !

@danielfrg
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants