Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shows wrong URL when using retrolab #25

Closed
yuvipanda opened this issue Nov 19, 2021 · 4 comments · Fixed by #27
Closed

Shows wrong URL when using retrolab #25

yuvipanda opened this issue Nov 19, 2021 · 4 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@yuvipanda
Copy link
Collaborator

Description

When I access the dialog from retrolab, I expect the link it gives me to also point to retrolab. Instead, it points to regular lab: http://localhost:8000/user/test/lab?token=5be7a94945cf47fb92e8598d5abe7387

Reproduce

  1. Install extension
  2. Open retrolab
  3. Go to Share -> Share Jupyter Server Link

Context

This is running in latest released retrolab and current master (+ #24) of this repo.
@yuvipanda yuvipanda added the bug Something isn't working label Nov 19, 2021
@yuvipanda
Copy link
Collaborator Author

I think

jupyterlab-link-share/src/index.ts

Line 61 in 761fec7

`${PageConfig.getUrl({
is not fully aware what URL it's on.

@yuvipanda
Copy link
Collaborator Author

I think on retrolab, it should also give you a link that opens the exact same view the user has right now.

@yuvipanda
Copy link
Collaborator Author

Looking at https://github.com/jupyterlab/jupyterlab/blob/ee1436736daf6f856d99ab125cc2b83592f6d196/packages/coreutils/src/pageconfig.ts#L142, it primarily hnadles single document mode vs lab, and different workspaces. I think we'll just need to implement this separately for retro, and just use the current URL + token.

@jtpio
Copy link
Member

jtpio commented Nov 19, 2021 •
edited
Loading

Right I think a custom plugin for retro will be needed, and can be implemented in this link share extension.

yuvipanda added a commit to yuvipanda/jupyterlab-link-share that referenced this issue Nov 19, 2021
@yuvipanda
Show correct URL when using retrolab
d145173 
- Provides direct link to notebook / directory the user is
  currently viewing
- Adds a JS dpeendency on @retrolab/application - I *think* this
  is the right way to detect if we are in retrolab? Alternatively
  we could check for app.name or similar. I'm hopefull this does
  not actually increase the built size of the extension too much?

Fixes jupyterlab-contrib#25
@yuvipanda yuvipanda mentioned this issue Nov 19, 2021
Merged
yuvipanda added a commit to yuvipanda/jupyterlab-link-share that referenced this issue Nov 19, 2021
@yuvipanda
Show correct URL when using retrolab
48a5f99 
- Provides direct link to notebook / directory the user is
  currently viewing
- Adds a JS dpeendency on @retrolab/application - I *think* this
  is the right way to detect if we are in retrolab? Alternatively
  we could check for app.name or similar. I'm hopefull this does
  not actually increase the built size of the extension too much?

Fixes jupyterlab-contrib#25
@jtpio jtpio closed this as completed in #27 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show correct URL when using retrolab yuvipanda/jupyterlab-link-share
2 participants
@yuvipanda @jtpio