Add a rudimentary warning to the link share dialog #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone with the token has full access to your server - including all your files - until you restart your server. We must make sure users know this. Moves the link into a textbox that autoselects on click, rather than just a link. Users don't actually want to click this - they only want to copy this. It also provides stylistic relief given we have so much more text there now.
|
Thanks! |
jtpio
reviewed
Nov 19, 2021
|
Failing check is unrelated again I think. |
This was referenced Nov 19, 2021
|
Check has passed! \o/ |
yuvipanda
added a commit
to yuvipanda/datahub
that referenced
this pull request
Nov 19, 2021
For use with data100 hub primarily. Brings in jupyterlab-contrib/jupyterlab-link-share#21 and jupyterlab-contrib/jupyterlab-link-share#24 Ref berkeley-dsep-infra#3027
yuvipanda
added a commit
to yuvipanda/datahub
that referenced
this pull request
Nov 19, 2021
For use with data100 hub primarily. Brings in jupyterlab-contrib/jupyterlab-link-share#21 and jupyterlab-contrib/jupyterlab-link-share#24 Ref berkeley-dsep-infra#3027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone with the token has full access to your server -
including all your files - until you restart your server.
We must make sure users know this.
Moves the link into a textbox that autoselects on click,
rather than just a link. Users don't actually want to click this -
they only want to copy this. It also provides stylistic relief
given we have so much more text there now.
This is how it looks now.