Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update completer extension example to the new APIs in Jlab 4.0 #190

Closed
wants to merge 2 commits into from
Closed

Update completer extension example to the new APIs in Jlab 4.0 #190

wants to merge 2 commits into from

Conversation

trungleduc
Copy link
Member

No description provided.

@welcome
Copy link

welcome bot commented Mar 3, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval changed the base branch from master to 4.0 March 3, 2022 13:33
@fcollonval
Copy link
Member

Thanks @trungleduc I pushed a 4.0 branch to be the target of features that are targeting that JLab version.

@trungleduc trungleduc changed the title Update completer extension example to the new APIs Update completer extension example to the new APIs in Lab 4 Mar 3, 2022
@trungleduc trungleduc changed the title Update completer extension example to the new APIs in Lab 4 Update completer extension example to the new APIs in Jlab 4.0 Mar 3, 2022
@trungleduc trungleduc marked this pull request as ready for review March 7, 2022 13:00
@fcollonval
Copy link
Member

Closing as added in #225

@fcollonval fcollonval closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @fcollonval