Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension examples 4.0 #225

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Update extension examples 4.0 #225

merged 2 commits into from
Apr 18, 2023

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Mar 28, 2023 •
edited
Loading

Update the extension examples for JupyterLab 4.0

@welcome
Copy link

welcome bot commented Mar 28, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@HaudinFlorence HaudinFlorence changed the base branch from master to 4.0 March 29, 2023 07:39
@brichet brichet marked this pull request as draft March 29, 2023 09:39
@HaudinFlorence HaudinFlorence force-pushed the update_extension_examples_4.0 branch 3 times, most recently from 06aed6f to 78331d7 Compare April 5, 2023 15:52
@fcollonval fcollonval mentioned this pull request Apr 6, 2023
Closed
@jtpio
Copy link
Member

jtpio commented Apr 7, 2023

Thanks for working on this!

@HaudinFlorence HaudinFlorence force-pushed the update_extension_examples_4.0 branch 2 times, most recently from 743772d to 9ee44ae Compare April 10, 2023 20:55
@brichet
Copy link
Collaborator

brichet commented Apr 14, 2023

It will probably be possible to clean up the examples when they are all updated.

We should keep only one LICENCE file at the root of the project, and also one RELEASE file maybe.

This is probably true also for .eslintrc.js, .prettierrc and .stylintrc.

@fcollonval
Copy link
Member

Thanks for the suggestion @brichet - it is also find to keep them as the goal is to have an example folder as close as the case obtain when starting from the extension template. So new comers won't be surprised by the absence of some files.

@fcollonval fcollonval marked this pull request as ready for review April 17, 2023 14:04
@fcollonval fcollonval force-pushed the update_extension_examples_4.0 branch from d3654df to 9c9b69e Compare April 17, 2023 14:33
@fcollonval fcollonval added the documentation Improvements or additions to documentation label Apr 17, 2023
@fcollonval fcollonval force-pushed the update_extension_examples_4.0 branch from 9c9b69e to e316912 Compare April 17, 2023 14:52
@fcollonval fcollonval added the enhancement New feature or request label Apr 17, 2023
@fcollonval @HaudinFlorence @brichet
Upgrade example for JupyterLab 4
d52e885 
Co-authored-by: Florence Haudin <haudin.florence@gmail.com>
Co-authored-by: Nicolas Brichet <nicolas.brichet@quantstack.net>
@fcollonval fcollonval force-pushed the update_extension_examples_4.0 branch from 8ff50e6 to d52e885 Compare April 17, 2023 16:55
@brichet brichet force-pushed the update_extension_examples_4.0 branch from a5b96b1 to 4ffc01e Compare April 18, 2023 12:04
fcollonval
fcollonval approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaudinFlorence and @brichet

@fcollonval fcollonval merged commit 5d57e09 into jupyterlab:4.0 Apr 18, 2023
@welcome
Copy link

welcome bot commented Apr 18, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

fcollonval added a commit that referenced this pull request Apr 18, 2023
@HaudinFlorence @fcollonval @brichet
Update extension examples 4.0 (#225)
e8016b1 
* Upgrade example for JupyterLab 4

Co-authored-by: Florence Haudin <haudin.florence@gmail.com>
Co-authored-by: Nicolas Brichet <nicolas.brichet@quantstack.net>

* Add pytest_jupyter[server] dependency in workflow

---------

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Nicolas Brichet <nicolas.brichet@quantstack.net>
This was referenced Apr 19, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@brichet brichet

@HaudinFlorence HaudinFlorence

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HaudinFlorence @jtpio @brichet @fcollonval @andrii-i