Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #7590

Merged
merged 7 commits into from
Dec 18, 2019
Merged

Update dependencies #7590

merged 7 commits into from
Dec 18, 2019

Conversation

lresende
Copy link
Member

@lresende lresende commented Dec 4, 2019 •
edited
Loading

Code changes

Few dependency updates in preparation for JupyterLab 2.0 release.

Usage

Update all dependencies (except jupyterlab) to latest
jlpm run update:dependency '^(?!@jupyterlab).*' latest --regex

Update all dependencies (except jupyterlab, codemirror, xterm) to latest
jlpm run update:dependency --regex '^(?!@jupyterlab|codemirror|@types/codemirror|xterm|linters).*' latest

Depends on #7599
Fixes #7194

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@lresende lresende added this to the 2.0 milestone Dec 6, 2019
@lresende lresende closed this Dec 10, 2019
@lresende lresende force-pushed the update_dependencies branch from 3177a9f to a074a65 Compare December 10, 2019 21:43
@lresende lresende reopened this Dec 10, 2019
@lresende lresende force-pushed the update_dependencies branch 3 times, most recently from e5c9a45 to 6bdffbc Compare December 12, 2019 21:35
@lresende lresende changed the title [WIP] Update dependencies Update dependencies Dec 12, 2019
@lresende lresende changed the title Update dependencies [WIP] Update dependencies Dec 12, 2019
@blink1073
Copy link
Contributor

@lresende, are you able to run jupyter lab --dev-mode locally with these changes? For me, the browser content never loads.

@lresende lresende force-pushed the update_dependencies branch from 6bdffbc to 8b2d6f2 Compare December 12, 2019 23:16
@lresende
Copy link
Member Author

@blink1073 let me look at that

@lresende
Copy link
Member Author

@blink1073 I looked at validating the behavior you described and it looks like this is a Firefox issue, as it's loading ok in Safari. @afshin also saw the same behavior. I will investigate it further to try to find the issue.

@lresende
Copy link
Member Author

Just a quick update:
jupyter lab --debug --dev-mode works in Chrome, Safari but fails in Firefox
jupyter lab --debug --core-mode seems to work fine in all browsers

I am still trying to identify what's going on with dev-mode in Firefox.

@blink1073
Copy link
Contributor

We narrowed it down: css-loader@<3.3.2 works fine 3.3.3 and 3.40 do not work (it times out loading styles). I couldn't think of a way to get a reproducible example to make an issue on the css-loader repo.

@lresende
Update linters and linters configuration
e374673 
Linter `lint-staged` configuration file has been updated
based on advanced configuration being deprecated and build
errors
@lresende
Update to Xterm 4.3
6142692 
Update how addons are handle
Include the fit addon which is now a separate package
Update to use new event handlers
@lresende
Update backward compatible changes to codemirror and its types
b936f63
@blink1073
Copy link
Contributor

We can't upgrade xterm yet because of xtermjs/xterm.js#2620. Our theme values are inherited from our CSS variables, which can include rgba() values, and currently only #rrggbbaa is supported.

@jasongrout
Copy link
Contributor

We can't upgrade xterm yet because of xtermjs/xterm.js#2620. Our theme values are inherited from our CSS variables, which can include rgba() values, and currently only #rrggbbaa is supported.

We're at xterm 3.13.2. Can we upgrade to 4.2, since from the issue it appears that the issue is with 4.3.0?

@lresende
Copy link
Member Author

We can't upgrade xterm yet because of xtermjs/xterm.js#2620. Our theme values are inherited from our CSS variables, which can include rgba() values, and currently only #rrggbbaa is supported.

We're at xterm 3.13.2. Can we upgrade to 4.2, since from the issue it appears that the issue is with 4.3.0?

Yes, xterm 4.2.0 seems to work fine.

@lresende lresende force-pushed the update_dependencies branch from 8b2d6f2 to 9536bc9 Compare December 18, 2019 01:45
@lresende
Revert to xterm < 4.3.0 to avoid theme/style related issues
d81965e 
We can't upgrade xterm yet because of xtermjs/xterm.js#2620.
Our theme values are inherited from our CSS variables, which
can include rgba() values, and currently only #rrggbbaa is
supported.
@lresende lresende force-pushed the update_dependencies branch from 9536bc9 to d81965e Compare December 18, 2019 01:54
@lresende lresende changed the title [WIP] Update dependencies Update dependencies Dec 18, 2019
@lresende
Copy link
Member Author

Thanks @blink1073 for helping debug some of the issues after some dependency updates.
All known issues should have been fixed and this pr has also been rebased to latest master and is ready for review/merge if no other issues are discovered.

@blink1073
Copy link
Contributor

Thanks @lresende!

@blink1073 blink1073 merged commit 13519d1 into jupyterlab:master Dec 18, 2019
@blink1073 blink1073 mentioned this pull request Dec 18, 2019
Closed
@jasongrout jasongrout mentioned this pull request Dec 30, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasongrout jasongrout Awaiting requested review from jasongrout

@blink1073 blink1073 Awaiting requested review from blink1073

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Upgrade packages for jlab 2.0
3 participants
@lresende @blink1073 @jasongrout