Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas selection doesn't accept rgba values in >=4.3 #2620

Closed
npezza93 opened this issue Dec 8, 2019 · 1 comment · Fixed by #2629
Closed

Canvas selection doesn't accept rgba values in >=4.3 #2620

npezza93 opened this issue Dec 8, 2019 · 1 comment · Fixed by #2629
Assignees
@Tyriar
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone
4.4.0

Comments

@npezza93
Copy link
Contributor

npezza93 commented Dec 8, 2019

In the demo run: term.setOption("theme", { selection: "rgba(255, 255, 255, 0.3)" })

This should set the selection to the default color but if you try to select something no color shows up.

Details

  • Browser and browser version: Safari and Electron
  • OS version: macOS Catalina
  • xterm.js version: master

Steps to reproduce

  1. Run the demo
  2. Execute term.setOption("theme", { selection: "rgba(255, 255, 255, 0.3)" })
  3. Click and drag to highlight
@npezza93 npezza93 changed the title Canvas selection doesn't accept rgba values in >=4.4 Canvas selection doesn't accept rgba values in >=4.3 Dec 8, 2019
@Tyriar
Copy link
Member

Tyriar commented Dec 8, 2019

I might have broken this with the min contrast ratio changes as I only explicitly supported the #rrggbbaa format

@Tyriar Tyriar added this to the 4.4.0 milestone Dec 8, 2019
@Tyriar Tyriar self-assigned this Dec 8, 2019
@blink1073 blink1073 mentioned this issue Dec 17, 2019
Merged
lresende added a commit to lresende/jupyterlab that referenced this issue Dec 18, 2019
@lresende
Revert to xterm <= 4.2.0 to avoid theme/style related issues
9536bc9 
We can't upgrade xterm yet because of xtermjs/xterm.js#2620.
Our theme values are inherited from our CSS variables, which
can include rgba() values, and currently only #rrggbbaa is
supported.
lresende added a commit to lresende/jupyterlab that referenced this issue Dec 18, 2019
@lresende
Revert to xterm < 4.3.0 to avoid theme/style related issues
d81965e 
We can't upgrade xterm yet because of xtermjs/xterm.js#2620.
Our theme values are inherited from our CSS variables, which
can include rgba() values, and currently only #rrggbbaa is
supported.
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 26, 2019
@Tyriar
Fix rgba() selection values
04ad642 
Fixes xtermjs#2620
@Tyriar Tyriar mentioned this issue Dec 26, 2019
Closed
@ivanwonder ivanwonder mentioned this issue Dec 26, 2019
Merged
@ivanwonder ivanwonder mentioned this issue Dec 27, 2019
Closed
@Tyriar Tyriar mentioned this issue Jan 6, 2020
Closed
@LabhanshAgrawal LabhanshAgrawal mentioned this issue Jan 22, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
4.4.0
2 participants
@Tyriar @npezza93