Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Route on file browser navigation #202

Merged

Conversation

fcollonval
Copy link
Member

Fixes #15

@welcome
Copy link

welcome bot commented Sep 1, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Binder 👈 Launch RetroLab on Binder

@jtpio
Copy link
Member

jtpio commented Sep 1, 2021

Thanks!

Does this also handle updating the URL when navigating folders, like in the classic notebook?

classic-file-browser-routing.mp4

@jtpio jtpio added the enhancement New feature or request label Sep 1, 2021
@jtpio jtpio added this to the 0.3.0 milestone Sep 1, 2021
@fcollonval
Copy link
Member Author

I'm unsure the error is relevant as it happens only on Chromium. Did you encounter random failure in the past?

@jtpio
Copy link
Member

jtpio commented Sep 1, 2021

I'm unsure the error is relevant as it happens only on Chromium. Did you encounter random failure in the past?

Not yet. Will restart the check to be sure.

@jtpio
Copy link
Member

jtpio commented Sep 1, 2021

Thanks for the update. Looks like it's almost ready to go.

When checking on Binder the base url gets appended once on first navigation:

baseurl-routing.mp4

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@jtpio jtpio merged commit ac9bac4 into jupyterlab:main Sep 2, 2021
@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

Will cut 0.3.3 with this and #203

@fcollonval fcollonval deleted the fix/Route-on-file-browser-navigation branch September 2, 2021 08:43
@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

0.3.3 is out: https://pypi.org/project/retrolab/0.3.3/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route on file browser navigation
2 participants