Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Add expose add in browser for galata #203

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 1, 2021

This add a configurable on the server expose_app_in_browser (like JupyterLab) to add access to the app object as window.jupyterapp (required by galata).

The name window.jupyterapp needs to be added in galata that assumes window.jupyterlab only for now. But it is complex to configure as it is part of the in-page JS helpers.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Binder 👈 Launch RetroLab on Binder

@jtpio jtpio added the enhancement New feature or request label Sep 1, 2021
@jtpio jtpio added this to the 0.3.0 milestone Sep 1, 2021
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0469e60 into jupyterlab:main Sep 1, 2021
@welcome
Copy link

welcome bot commented Sep 1, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval deleted the ft/add-app-in-browser branch September 1, 2021 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants