Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for deploying a demo to GitHub Pages #9

Merged
merged 4 commits into from
May 29, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 29, 2024

Fixes #4

@jtpio jtpio added the documentation Improvements or additions to documentation label May 29, 2024
@jtpio
Copy link
Member Author

jtpio commented May 29, 2024

Looking good trying the built archive locally:

image

@jtpio jtpio marked this pull request as ready for review May 29, 2024 19:00
@jtpio
Copy link
Member Author

jtpio commented May 29, 2024

Merging to see if that works on the real GitHub pages deployment.

@jtpio jtpio merged commit ccfb585 into jupyterlite:main May 29, 2024
8 checks passed
@jtpio jtpio deleted the demo branch May 29, 2024 19:02
@ianthomas23
Copy link
Member

Thanks for this!

@ianthomas23
Copy link
Member

To clarify, if we make changes to cockle then for them to appear in the github pages deployment we need a new release of cockle and a PR or push to main branch here?

@jtpio
Copy link
Member Author

jtpio commented May 30, 2024

Yes we need to update the dependency in package.json (and update the yarn.lock):

"@jupyterlite/cockle": "^0.0.3",

And open a PR here and merge it into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo using binder
2 participants