Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Bitpay] Add order id as the reference id #2591

Merged
merged 6 commits into from
Nov 6, 2023
Merged

feat(connector): [Bitpay] Add order id as the reference id #2591

merged 6 commits into from
Nov 6, 2023

Conversation

ashh1215
Copy link
Contributor

@ashh1215 ashh1215 commented Oct 15, 2023 •
edited by deepanshu-iiitu
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Relevant documentation

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #2325

How did you test it?

Make any Payment for connector Bitpay and see that you are getting "reference_id" field in the payments response of hyperswitch. It should not be null.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ashh1215 ashh1215 requested a review from a team as a code owner October 15, 2023 04:51
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 15, 2023
@prasunna09 prasunna09 added this to the October 2023 Milestone milestone Oct 15, 2023
@ashh1215 ashh1215 changed the title feat(connector): [Bitpay] Add order id as the reference id feat(connector): [Bitpay] Added order id as the reference id Oct 15, 2023
@ashh1215 ashh1215 changed the title feat(connector): [Bitpay] Added order id as the reference id feat(connector): [Bitpay] Add order id as the reference id Oct 15, 2023
@ashh1215
Copy link
Contributor Author

@SanchithHegde Please do review and suggest changes if required

deepanshu-iiitu
deepanshu-iiitu requested changes Oct 31, 2023
View reviewed changes
crates/router/src/connector/bitpay/transformers.rs Outdated
@@ -138,7 +138,7 @@ impl<F, T>
mandate_reference: None,
connector_metadata: None,
network_txn_id: None,
connector_response_reference_id: None,
connector_response_reference_id: Some(item.response.data.id),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
connector_response_reference_id: Some(item.response.data.id),
connector_response_reference_id: item.response.data.order_id.or(Some(connector_id)),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashh1215

@deepanshu-iiitu deepanshu-iiitu added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 31, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @ashh1215
Thanks for your interest in contributing to hyperswitch.
Let us know if you need any assistance from our end.
.
Also, even if hacktoberfest is over, we should celebrate open source everyday and we are open for more contributions from you.
We would still be rewarding folks with goodies even if the PR gets merged post hacktoberfest.
May the Source be with you!

@ashh1215
Copy link
Contributor Author

ashh1215 commented Nov 2, 2023 •
edited
Loading

Hey
I'll add the changes soon.
Thanks for the feedback.

@ashh1215
Copy link
Contributor Author

ashh1215 commented Nov 2, 2023

@deepanshu-iiitu
I've made the changes. Please review.
Thank you.

@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Nov 2, 2023 •
edited
Loading

Hey @ashh1215,
Thanks for your quick response. Pls address the CI fails
Run cargo clippy and addressed lints thrown by it.

@AkshayaFoiger AkshayaFoiger removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Nov 3, 2023
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Nov 3, 2023
View reviewed changes
@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Nov 3, 2023 •
edited by deepanshu-iiitu
Loading

@ashh1215, please run cargo +nightly fmt and then commit the code

@ashh1215
Copy link
Contributor Author

ashh1215 commented Nov 3, 2023

@deepanshu-iiitu I've fixed the issues. It should work now.

deepanshu-iiitu
deepanshu-iiitu approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto-merge was automatically disabled November 6, 2023 10:45

Merge queue setting changed

SanchithHegde
SanchithHegde approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @ashh1215!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 6, 2023
@SanchithHegde SanchithHegde added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Nov 6, 2023
Merged via the queue into juspay:main with commit d47d4ac Nov 6, 2023
11 checks passed
@deepanshu-iiitu
Copy link
Contributor

Hey @ashh1215 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

@prasunna09 prasunna09 Awaiting requested review from prasunna09

Assignees

@ashh1215 ashh1215

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Bitpay] Use connector_response_reference_id as reference to merchant
6 participants
@ashh1215 @AkshayaFoiger @deepanshu-iiitu @SanchithHegde @prasunna09 @bernard-eugine