-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): introduce new attempt and intent status to handle multiple partial captures #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0b0860.
hrithikesh026
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Nov 7, 2023
pixincreate
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added what I observed..
...appy Cases/Scenario14-Save card payment with manual capture/Payments - Capture/event.test.js
Show resolved
Hide resolved
Narayanbhat166
requested changes
Nov 9, 2023
migrations/2023-11-06-153840_introduce_new_attempt_and_intent_status/up.sql
Outdated
Show resolved
Hide resolved
migrations/2023-11-06-153840_introduce_new_attempt_and_intent_status/down.sql
Outdated
Show resolved
Hide resolved
…status/up.sql Co-authored-by: Narayan Bhat <48803246+Narayanbhat166@users.noreply.github.com>
…status/down.sql Co-authored-by: Narayan Bhat <48803246+Narayanbhat166@users.noreply.github.com>
Narayanbhat166
previously approved these changes
Nov 9, 2023
Kindly check the deployment readiness. |
jarnura
previously approved these changes
Nov 16, 2023
hrithikesh026
dismissed stale reviews from jarnura and Narayanbhat166
via
November 16, 2023 10:36
8588a31
Narayanbhat166
previously approved these changes
Nov 16, 2023
Narayanbhat166
approved these changes
Nov 16, 2023
jarnura
approved these changes
Nov 16, 2023
pixincreate
approved these changes
Nov 16, 2023
likhinbopanna
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Nov 16, 2023
@SanchithHegde, can you look into |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
(1) Currently, single 'manual' capture results in 'succeeded'(intent) and 'charged'(attempt) statuses during a successful full/partial capture.
(2) 'Multiple manual' capture results in:
(a) 'partially captured'(intent) and 'partially charged'(attempt) when amount_capturable>0
(b) 'succeeded' (intent) and 'charged' (attempt) statuses when amount_capturable=0 after a successful capture
(c) 'succeeded'(intent) and 'voided'(attempt) when a void call is made after at least one successful partial capture
(d) 'cancelled'(attempt) and 'voided'(intent) when a void call is made even before one successful partial capture
In order to address the incongruity in intent vs attempt statuses in (2)(c) case, we would need to introduce another set of non-terminal statuses ['partially captured and capturable' (intent); 'partially captured and capturable'(attempt)] which would be mapped to (2)(a) case above whereas the 'partially captured'(intent) and 'partially charged'(attempt) statuses would be mapped to (2)(c) case.
Even in case of single 'partial' captures, the statuses should be updated to 'partially captured'(intent) and 'partially charged'(attempt).
Additional Changes
Motivation and Context
How did you test it?
Manual
Checklist
cargo +nightly fmt --all
cargo clippy