Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status goes from pending to partially captured in psync #2935

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Nov 21, 2023

Type of Change

  • Bugfix

Description

Original PR: #2802
Hotfix branch PR for this Main branch PR #2915

Currently, for a connector that returns processing status for full manual capture, if Psync is done later, status would always go from processing to partially_captured instead of succeeded.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  1. Create a merchant
  2. Create a connector that returns processing status for single full capture. Then later gives succeeded after some time.
  3. Create a payment with confirm = true and capture_method = manual.
  4. Capture the payment fully. (status should be processing)
  5. later do force sync. (status should be succeeded)

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@hrithikesh026 hrithikesh026 self-assigned this Nov 21, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners November 21, 2023 11:26
@hrithikesh026 hrithikesh026 changed the title fix: psync status fix hotfix 1.84.0 fix: status goes from pending to partially captured in psync Nov 21, 2023
@SanchithHegde SanchithHegde merged commit 2461675 into hotfix-1.84.0 Nov 21, 2023
10 of 13 checks passed
@SanchithHegde SanchithHegde deleted the psync_status_fix_hotfix-1.84.0 branch November 21, 2023 18:26
@SanchithHegde SanchithHegde added the C-bug Category: Bug label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants