-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: status goes from pending to partially captured in psync #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Nov 17, 2023
jarnura
previously approved these changes
Nov 20, 2023
prasunna09
previously approved these changes
Nov 20, 2023
hrithikesh026
dismissed stale reviews from prasunna09 and jarnura
via
November 20, 2023 11:50
1c97eb0
Narayanbhat166
approved these changes
Nov 21, 2023
jarnura
approved these changes
Nov 21, 2023
7 tasks
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Status would always go from
Processing
toPartiallyCaptured
if force sync is done. Fixed it.Other fixes and changes:
In payment_create, with
confirm = true
andcapture_method = manual
, if someamount_to_capture
is sent in request body, it is updated in DB but the amount sent to connector will always beamount
. So it is possible that amount_to_capture can be less than original amount but the original amount is sent to connector. Fixed it by requiringamount_to_capture
to be equal toamount
ifconfirm = true
andautomatic
capturesurcharge amount wouldn't get updated in DB if connector returns error response. Fixed it.
amount_to_capture was not getting updated in DB if sent in payment_capture call. Fixed it.
Additional Changes
Motivation and Context
How did you test it?
Manual
Before PSync
After PSync
Checklist
cargo +nightly fmt --all
cargo clippy