-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): mask pii information in connector request and response for stripe, aci, adyen, airwallex and authorizedotnet #3678
Conversation
…tor-responses-in-connector-events
…tor-responses-in-connector-events
…tor-responses-in-connector-events
…tor-responses-in-connector-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Stripe, payment_method
field in paymentIntentRequest is needed to be masked? Please make the change accordingly!
@@ -3629,17 +3637,17 @@ pub struct Evidence { | |||
#[serde(rename = "evidence[customer_communication]")] | |||
pub customer_communication: Option<String>, | |||
#[serde(rename = "evidence[customer_email_address]")] | |||
pub customer_email_address: Option<String>, | |||
pub customer_email_address: Option<Secret<String>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use Option<Secret<Email>>
#[serde(rename = "evidence[customer_purchase_ip]")] | ||
pub customer_purchase_ip: Option<String>, | ||
pub customer_purchase_ip: Option<Secret<String>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Option<Secret<String, pii::IpAddress>>>
acd5141
…stman-runner * 'main' of github.com:juspay/hyperswitch: (22 commits) chore(version): 2024.02.28.0 chore(postman): update Postman collection files fix(connector): [AUTHORIZEDOTNET] Fix status mapping (#3845) refactor(router): added logs health and deep health (#3780) feat(roles): Change list roles, get role and authorization info api to respond with groups (#3837) fix(core): validate amount_to_capture in payment update (#3830) refactor(connector): [Square] change error message from NotSupported to NotImplemented (#2875) feat(router): add connector mit related columns to the payment methods table (#3764) ci(postman): refactor NMI postman collection (#3805) refactor(connector): [Braintree] Mask PII data (#3759) refactor(connector): [Forte] Mask PII data (#3824) refactor(compatibility): added compatibility layer request logs (#3774) refactor(payment_methods): introduce `locker_id` column in `payment_methods` table (#3760) feat(connector): mask pii information in connector request and response for stripe, aci, adyen, airwallex and authorizedotnet (#3678) chore(version): 2024.02.27.0 fix(core): do not construct request if it is already available (#3826) refactor: incorporate `hyperswitch_interface` into router (#3669) feat: add unique constraint restriction for KV (#3723) feat(connector): [Payme] Add Void flow to Payme (#3817) refactor(connector): [Cybersource] Mask PII data (#3786) ...
Type of Change
Description
Mask pii information passed and received in the connector request and response for stripe, aci, adyen, airwallex and authorizedotnet
Test Case
Check if sensitive fields within connector request and response is masked in the click house for all these connectors
2.ACI mandate payment
Stripe Apple pay
Authorize.dot Mandate Payment and refund
Note: can't be tested, there is a known bug
Check if all the sensitive data in the
masked_response
is maskedNote: There is a known bug in adyen recurring mandate payment
7.Response for Airwallex 3DS
Checklist
cargo +nightly fmt --all
cargo clippy