fix(core): validate amount_to_capture in payment update #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-bug
Narayanbhat166
previously approved these changes
Feb 27, 2024
|
Your changes seems to affect other connectors (In CI, it is found to affect Stripe): https://github.com/juspay/hyperswitch/actions/runs/8053593266/job/21996336428?pr=3830. |
Narayanbhat166
approved these changes
Feb 27, 2024
sai-harsha-vardhan
approved these changes
Feb 27, 2024
|
Also, can you please check the same for other connectors i.e., adyen, bluesnap, cybersource, checkout? |
pixincreate
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Feb 28, 2024
…stman-runner * 'main' of github.com:juspay/hyperswitch: (22 commits) chore(version): 2024.02.28.0 chore(postman): update Postman collection files fix(connector): [AUTHORIZEDOTNET] Fix status mapping (#3845) refactor(router): added logs health and deep health (#3780) feat(roles): Change list roles, get role and authorization info api to respond with groups (#3837) fix(core): validate amount_to_capture in payment update (#3830) refactor(connector): [Square] change error message from NotSupported to NotImplemented (#2875) feat(router): add connector mit related columns to the payment methods table (#3764) ci(postman): refactor NMI postman collection (#3805) refactor(connector): [Braintree] Mask PII data (#3759) refactor(connector): [Forte] Mask PII data (#3824) refactor(compatibility): added compatibility layer request logs (#3774) refactor(payment_methods): introduce `locker_id` column in `payment_methods` table (#3760) feat(connector): mask pii information in connector request and response for stripe, aci, adyen, airwallex and authorizedotnet (#3678) chore(version): 2024.02.27.0 fix(core): do not construct request if it is already available (#3826) refactor: incorporate `hyperswitch_interface` into router (#3669) feat: add unique constraint restriction for KV (#3723) feat(connector): [Payme] Add Void flow to Payme (#3817) refactor(connector): [Cybersource] Mask PII data (#3786) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
If capture method is automatic then
amountmust be equal toamount_to_capture, ifamount_to_captureis sent in payment_create request.This validation works in payments_create call but doesn't work as expected in payments_update call.
Additional Changes
Motivation and Context
How did you test it?
Manual
Payment create with confirm false
Update payment amount (fails with validation error)
Send correct
amount_to_capturefield and update is successfulChecklist
cargo +nightly fmt --allcargo clippy