Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: [Fiserv] Remove Default Case Handling #4767

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

ind1goDusk
Copy link
Contributor

@ind1goDusk ind1goDusk commented May 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR closes #4059
removes the default case handling in hyperswitch/crates/router/src/connector/fiserv/transformer.rs.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

hyperswitch/crates/router/src/connector/fiserv/transformer.rs

Motivation and Context

How did you test it?

No testing required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ind1goDusk ind1goDusk requested a review from a team as a code owner May 26, 2024 16:39
@ind1goDusk ind1goDusk changed the title [REFACTOR]: [Fiserv] Remove Default Cast Handling Refactor: [Fiserv] Remove Default Cast Handling May 26, 2024
@pixincreate pixincreate changed the title Refactor: [Fiserv] Remove Default Cast Handling Refactor: [Fiserv] Remove Default Case Handling May 26, 2024
@ind1goDusk
Copy link
Contributor Author

still waiting on review

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Jun 11, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 24, 2024
Merged via the queue into juspay:main with commit 9caabef Jun 24, 2024
19 checks passed
pixincreate added a commit that referenced this pull request Jun 24, 2024
…ough-hyperswitch-cypress

* 'main' of github.com:juspay/hyperswitch:
  feat(router): add support for googlepay step up flow (#2744)
  fix(access_token): use `merchant_connector_id` in access token (#5106)
  feat: added kafka events for authentication create and update (#4991)
  feat(ci): add vector to handle logs pipeline (#5021)
  feat(users): Decision manager flow changes for SSO (#4995)
  ci(cypress): Fix payment method id for non supported connectors (#5075)
  refactor(core): introduce an interface to switch between old and new connector integration implementations on the connectors (#5013)
  refactor(events): populate object identifiers in outgoing webhooks analytics events during retries (#5067)
  Refactor: [Fiserv] Remove Default Case Handling (#4767)
  chore(version): 2024.06.24.0
  fix(router): avoid considering pre-routing results during `perform_session_token_routing` (#5076)
  refactor(redis): spawn one subscriber thread for handling all the published messages to different channel (#5064)
  feat(users): setup user authentication methods schema and apis (#4999)
  feat(payment_methods): Implement Process tracker workflow for Payment method Status update (#4668)
  chore(version): 2024.06.20.1
  chore(postman): update Postman collection files
  fix(payment_methods): support last used for off session token payments (#5039)
  ci(postman): add net_amount field test cases (#3286)
  refactor(connector): [Mifinity]dynamic fields for mifinity (#5056)
  refactor(payment_method): [Klarna] store and populate payment_type for klarna_sdk Paylater in response (#4956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [Fiserv] Remove Default Case Handling
4 participants