Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cypress): Fix payment method id for non supported connectors #5075

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented Jun 21, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Added hooks for payment method id mandates test cases as it was missed
  • Added bank redirect cases for Paypal
  • Fixed ideal bank redirect as UI has been changed

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Test cases were failing for non supported connectors

How did you test it?

Cypress:

  • Trustpay
image
  • Stripe
image
  • Cybersource
image
  • Bankofamerica
image
  • nmi
image

[2 failures are because of issue in sandbox , needs to be fixed ]

  • adyen
image
  • paypal
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 21, 2024
@likhinbopanna likhinbopanna added this to the June 2024 Release milestone Jun 21, 2024
@likhinbopanna likhinbopanna self-assigned this Jun 21, 2024
@likhinbopanna likhinbopanna requested review from a team as code owners June 21, 2024 14:32
@@ -485,7 +485,7 @@ export const connectorDetails = {
type: "invalid_request",
message: "Payment method type not supported",
code: "HE_03",
reason: "debit mandate payment is not supported by trustpay",
reason: "manual is not supported by trustpay",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need some discussion around this, other than that, LGTM!

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 9600461 Jun 24, 2024
19 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-payment-method-id branch June 24, 2024 12:24
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 24, 2024
pixincreate added a commit that referenced this pull request Jun 24, 2024
…ough-hyperswitch-cypress

* 'main' of github.com:juspay/hyperswitch:
  feat(router): add support for googlepay step up flow (#2744)
  fix(access_token): use `merchant_connector_id` in access token (#5106)
  feat: added kafka events for authentication create and update (#4991)
  feat(ci): add vector to handle logs pipeline (#5021)
  feat(users): Decision manager flow changes for SSO (#4995)
  ci(cypress): Fix payment method id for non supported connectors (#5075)
  refactor(core): introduce an interface to switch between old and new connector integration implementations on the connectors (#5013)
  refactor(events): populate object identifiers in outgoing webhooks analytics events during retries (#5067)
  Refactor: [Fiserv] Remove Default Case Handling (#4767)
  chore(version): 2024.06.24.0
  fix(router): avoid considering pre-routing results during `perform_session_token_routing` (#5076)
  refactor(redis): spawn one subscriber thread for handling all the published messages to different channel (#5064)
  feat(users): setup user authentication methods schema and apis (#4999)
  feat(payment_methods): Implement Process tracker workflow for Payment method Status update (#4668)
  chore(version): 2024.06.20.1
  chore(postman): update Postman collection files
  fix(payment_methods): support last used for off session token payments (#5039)
  ci(postman): add net_amount field test cases (#3286)
  refactor(connector): [Mifinity]dynamic fields for mifinity (#5056)
  refactor(payment_method): [Klarna] store and populate payment_type for klarna_sdk Paylater in response (#4956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants