refactor(cypress): unify fixtures in tests & follow conventions #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
force-pushed
the
fixtures-unify-cypress
branch
from
9036ba1 to
8449a7f
Compare
pixincreate
changed the title
This was referenced Jul 3, 2024
…ify-cypress * 'main' of github.com:juspay/hyperswitch: (22 commits) refactor: Adding millisecond to Kafka timestamp (#5202) chore(version): 2024.07.05.0 fix(user_auth_method): make id option in auth select (#5213) Docs: Updated API - ref for payments (#5172) feat(core): add merchant order reference id (#5197) feat(analytics): Refund status serialization issue for ckh analytics (#5199) fix(router): `override setup_future_usage` filed to on_session based on merchant config (#5195) feat(cypress): make tests forcefully skippable (#5176) feat(core): Added integrity framework for Authorize and Sync flow with connector as Stripe (#5109) ci(cypress): Update card number for adyen and status for paypal (#5192) refactor(cypress): error handling and add sync refunds in places where missing (#5128) feat(analytics): FRM Analytics (#4880) chore(version): 2024.07.04.0 feat(pm_auth): Added balance check for PM auth bank account (#5054) refactor(payment_methods): add appropriate missing logs (#5190) refactor(migrations): add commands to make file to run migrations for api v2 (#5169) chore(version): 2024.07.03.0 fix(event): Updated the ApiEventMetric (#5126) feat(router): add refunds manual-update api (#5094) refactor(payment_link): logs payment links logs coverage (#4918) ...
…ify-cypress * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.07.08.0 fix(connector): [adyen] remove browser info for mit and [paypal] add refund key in headers (#5225) chore(version): 2024.07.06.0 feat(router): Pass the shipping email whenever the billing details are included in the session token response (#5228) fix(cypress): fix metadata missing while creating connector if not in auth (#5215) refactor: fix unit and documentation tests (#4754) feat(events): add hashed customer_email and feature_metadata (#5220) feat(events): Add payment metadata to hyperswitch-payment-intent-events (#5170) fix(analytics): using HashSet to represent the returned metrics (#5179) feat(core): billing_details inclusion in Payment Intent (#5090) feat(router): pass fields to indicate if the customer address details to be connector from wallets (#5210) fix(refunds): Add aliases on refund status for backwards compatibility (#5216) Feat(connector): [BRAINTREE] Implement Card Mandates (#5204)
…ify-cypress * 'main' of github.com:juspay/hyperswitch: fix(cypress): remove unsupported manual confirm tests (#5223)
14 tasks
Gnanasundari24
approved these changes
Jul 10, 2024
Sakilmostak
approved these changes
Jul 10, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently, in Cypress test files, individual fixtures have been imported and there are instances where different names are given which is leading to confusion. We need to unify the imports. This can be done by creating
imports.jsfile in fixtures and import all the files in it and export it from there. Import thisimports.jsin all the test files.Adding to this, another minor change has been introduced where inconsistencies has been addressed (
utils.jsrenamed toUtils.jsandCommon.jshas been renamed toCommons.js)Additional Changes
Motivation and Context
NIL
How did you test it?
Checklist
prettier . --writecargo clippy