Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cypress): Fix payouts failing #5239

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(cypress): Fix payouts failing #5239

merged 2 commits into from
Jul 8, 2024

Conversation

pixincreate
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes bug introduced in #5223

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Payouts for other connectors started to fail they did not skip

How did you test it?

Tests have been added here: #5180

Checklist

  • I formatted the code prettier . --write
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 8, 2024
@pixincreate pixincreate added this to the July 2024 Release milestone Jul 8, 2024
@pixincreate pixincreate self-assigned this Jul 8, 2024
@pixincreate pixincreate requested review from a team as code owners July 8, 2024 08:23
@likhinbopanna likhinbopanna enabled auto-merge July 8, 2024 08:27
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 864d53c Jul 8, 2024
15 checks passed
@likhinbopanna likhinbopanna deleted the fix-payouts branch July 8, 2024 09:19
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhinbopanna likhinbopanna likhinbopanna approved these changes

@kashif-m kashif-m kashif-m approved these changes

@Sakilmostak Sakilmostak Awaiting requested review from Sakilmostak

Assignees

@pixincreate pixincreate

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
July 2024 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pixincreate @kashif-m @likhinbopanna