Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env variable for enable key manager service #5465

Merged

Conversation

ArjunKarthik
Copy link
Contributor

@ArjunKarthik ArjunKarthik commented Jul 29, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption. Once the config is enabled it shouldn't be disabled. Hotfix PR of #5442

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption.

How did you test it?

This can't be tested in Test environment, since it is already enabled in both

  1. key_manager.enabled: false and feature "encryption_service" disabled. Encryption and decryption happens within the application
  2. key_manager.enabled: true and feature "encryption_service" disabled. Encryption and decryption happens within the application
  3. key_manager.enabled: false and feature "encryption_service" enabled. Encryption and decryption happens within the application
  4. key_manager.enabled: true and feature "encryption_service" enabled. Encryption and decryption happens with encryption service. Once this is enabled can't be disabled.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

Co-authored-by: dracarys18 <karthikey.hegde@juspay.in>
@ArjunKarthik ArjunKarthik added C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes labels Jul 29, 2024
@ArjunKarthik ArjunKarthik self-assigned this Jul 29, 2024
@ArjunKarthik ArjunKarthik requested a review from a team as a code owner July 29, 2024 09:28
@ArjunKarthik ArjunKarthik changed the base branch from main to hotfix-2024.07.26.0 July 29, 2024 09:28
@ArjunKarthik ArjunKarthik changed the title feat: add env variable for enable key manager service feat: add env variable for enable key manager service #5442 Jul 29, 2024
@ArjunKarthik ArjunKarthik changed the title feat: add env variable for enable key manager service #5442 feat: add env variable for enable key manager service Jul 29, 2024
@Gnanasundari24 Gnanasundari24 merged commit 70258e3 into hotfix-2024.07.26.0 Jul 29, 2024
32 of 39 checks passed
@Gnanasundari24 Gnanasundari24 deleted the hf-keymanager-runtime-feature-flag branch July 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Hotfix changes for Create env variable for enabling keymanager service
3 participants