feat: add env variable for enable key manager service #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArjunKarthik
added
C-feature
2 tasks
SanchithHegde
previously approved these changes
Jul 25, 2024
dracarys18
previously approved these changes
Jul 25, 2024
jarnura
previously approved these changes
Jul 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dracarys18
dismissed stale reviews from SanchithHegde, jarnura, and themself
via
3f9ac3d
dracarys18
approved these changes
Jul 29, 2024
pixincreate
added
the
S-waiting-on-review
jarnura
approved these changes
Jul 29, 2024
ArjunKarthik
removed
the
S-waiting-on-review
ArjunKarthik
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: dracarys18 <karthikey.hegde@juspay.in>
13 tasks
pixincreate
added a commit
that referenced
this pull request
Jul 30, 2024
* 'main' of github.com:juspay/hyperswitch: refactor(router): remove `connector_account_details` and `connector_webhook_details` in merchant_connector_account list response (#5457) feat: add env variable for enable key manager service (#5442) chore(version): 2024.07.29.0 feat(payments): support sort criteria in payments list (#5389) refactor(connector): add amount conversion framework to placetopay (#4988) feat(connector): [Bambora APAC] add mandate flow (#5376) ci: set code owners for payment methods files (#5453) refactor(opensearch): Add Error Handling for Empty Query and Filters in Request (#5432) chore: address Rust 1.80 clippy lints (#5447) feat(connector): [FISERV] Move connector to hyperswitch_connectors (#5441) ci: add support for just hack_v2 check for PRs (#5426) fix: added created at and modified at keys in PaymentAttemptResponse (#5412) refactor(merchant_account_v2): recreate id for `merchant_account` v2 (#5439) chore(version): 2024.07.26.0 feat(events): forward the tenant configuration as part of the kafka message (#5224) refactor(connector): add amount conversion framework to payone (#4981) refactor(user_roles): make org and merchant id nullable (#5353) fix(euclid): change the address taken in SessionFlowRouting from shipping to billing address (#5435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption. Once the config is enabled it shouldn't be disabled.
Additional Changes
Motivation and Context
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption.
How did you test it?
This can't be tested in Test environment, since it is already enabled in both
Checklist
cargo +nightly fmt --allcargo clippy