-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): forward the tenant configuration as part of the kafka message #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsampras
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a screenshot of the Audit events as well for e.g PaymentCancel
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 16, 2024
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 23, 2024
lsampras
reviewed
Jul 24, 2024
tsdk02
approved these changes
Jul 24, 2024
lsampras
approved these changes
Jul 25, 2024
SanchithHegde
added
the
M-configuration-changes
Metadata: This PR involves configuration changes
label
Jul 25, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 30, 2024
* 'main' of github.com:juspay/hyperswitch: refactor(router): remove `connector_account_details` and `connector_webhook_details` in merchant_connector_account list response (#5457) feat: add env variable for enable key manager service (#5442) chore(version): 2024.07.29.0 feat(payments): support sort criteria in payments list (#5389) refactor(connector): add amount conversion framework to placetopay (#4988) feat(connector): [Bambora APAC] add mandate flow (#5376) ci: set code owners for payment methods files (#5453) refactor(opensearch): Add Error Handling for Empty Query and Filters in Request (#5432) chore: address Rust 1.80 clippy lints (#5447) feat(connector): [FISERV] Move connector to hyperswitch_connectors (#5441) ci: add support for just hack_v2 check for PRs (#5426) fix: added created at and modified at keys in PaymentAttemptResponse (#5412) refactor(merchant_account_v2): recreate id for `merchant_account` v2 (#5439) chore(version): 2024.07.26.0 feat(events): forward the tenant configuration as part of the kafka message (#5224) refactor(connector): add amount conversion framework to payone (#4981) refactor(user_roles): make org and merchant id nullable (#5353) fix(euclid): change the address taken in SessionFlowRouting from shipping to billing address (#5435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Enhance the KafkaProducer struct to include a clickhouse_db_name field. This field is needed for generating audit events that do not use KafkaStore. Additionally, we will implement a method to add tenant details within KafkaProducer and propagate this functionality through EventsHandler.
Additional Changes
Motivation and Context
This is to support multitenancy.
How did you test it?
After making a payment, you can observe a new field added at the end:
clickhouse_database = default
for[Topics] hyperswitch-payment-attempt-events
for sandbox theclickhouse_database
should have thehyperswitch_sandbox
or the current clickhouse db in use.Checklist
cargo +nightly fmt --all
cargo clippy