Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(merchant_account_v2): recreate id for merchant_account v2 #5439

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • Refactoring

Description

This PR adds the column id in merchant_account with a type of Varchar. This will be used to store the global id, that is generated by MerchantName.

Additional Changes

  • This PR modifies the database schema

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 requested review from a team as code owners July 25, 2024 09:23
@Narayanbhat166 Narayanbhat166 self-assigned this Jul 25, 2024
@Narayanbhat166 Narayanbhat166 added C-refactor Category: Refactor api-v2 labels Jul 25, 2024
@Narayanbhat166 Narayanbhat166 added this to the July 2024 Release milestone Jul 25, 2024
SanchithHegde
SanchithHegde previously approved these changes Jul 25, 2024
Comment on lines +8 to +9
UPDATE merchant_account
SET id = merchant_id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query can lock the entire table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should not be run in higher environments

@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 93976db Jul 26, 2024
13 checks passed
@likhinbopanna likhinbopanna deleted the recreate_id_for_merchant_v2 branch July 26, 2024 07:32
kashif-m pushed a commit that referenced this pull request Jul 26, 2024
…5439)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
pixincreate added a commit that referenced this pull request Jul 30, 2024
* 'main' of github.com:juspay/hyperswitch:
  refactor(router): remove `connector_account_details` and `connector_webhook_details` in merchant_connector_account list response (#5457)
  feat: add env variable for enable key manager service (#5442)
  chore(version): 2024.07.29.0
  feat(payments): support sort criteria in payments list (#5389)
  refactor(connector):  add amount conversion framework to placetopay (#4988)
  feat(connector): [Bambora APAC] add mandate flow (#5376)
  ci: set code owners for payment methods files (#5453)
  refactor(opensearch): Add Error Handling for Empty Query and Filters in Request (#5432)
  chore: address Rust 1.80 clippy lints (#5447)
  feat(connector): [FISERV] Move connector to hyperswitch_connectors (#5441)
  ci: add support for just hack_v2 check for PRs (#5426)
  fix: added created at and modified at keys in PaymentAttemptResponse (#5412)
  refactor(merchant_account_v2): recreate id for `merchant_account` v2  (#5439)
  chore(version): 2024.07.26.0
  feat(events): forward the tenant configuration as part of the kafka message (#5224)
  refactor(connector):  add amount conversion framework to payone (#4981)
  refactor(user_roles): make org and merchant id nullable (#5353)
  fix(euclid): change the address taken in SessionFlowRouting from shipping to billing address (#5435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-v2 C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants