Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: populate payment method details in payments response #5785

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: populate payment method details in payments response #5785

merged 1 commit into from
Sep 4, 2024

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Sep 3, 2024

Reverts #5661

@lsampras lsampras requested review from a team as code owners September 3, 2024 13:47
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 3, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 8 of 10 files.

Overall, the semantic diff is 5% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/core/payments/helpers.rs 44.98% smaller
✔️ crates/openapi/src/openapi.rs 1.85% smaller
✔️ crates/openapi/src/openapi_v2.rs 1.85% smaller
✔️ crates/masking/src/lib.rs Analyzed
❔ crates/masking/src/masked_string.rs Unsupported file format
✔️ crates/hyperswitch_domain_models/src/payment_method_data.rs 0.99% smaller
✔️ crates/api_models/src/payments.rs 49.42% smaller
❔ crates/api_models/src/payments/additional_info.rs Unsupported file format
✔️ api-reference-v2/openapi_spec.json Analyzed
✔️ api-reference/openapi_spec.json Analyzed

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 3, 2024
@kashif-m kashif-m changed the title Revert "feat: populate payment method details in payments response" feat(revert): populate payment method details in payments response Sep 4, 2024
@kashif-m kashif-m linked an issue Sep 4, 2024 that may be closed by this pull request
[FEATURE] Payments and it's webhook response to contain non-card payment method details #5652
Closed
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit c84af20 Sep 4, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the revert-5661-5652-feature-payments-and-its-webhook-response-to-contain-non-card-payment-method-details branch September 4, 2024 07:53
kashif-m pushed a commit that referenced this pull request Sep 4, 2024
@lsampras @kashif-m
feat(revert): populate payment method details in payments response (#…
3b34c77 
…5785)

(cherry picked from commit c84af20)
@kashif-m kashif-m mentioned this pull request Sep 4, 2024
Merged
14 tasks
@likhinbopanna likhinbopanna changed the title feat(revert): populate payment method details in payments response feat: populate payment method details in payments response Sep 4, 2024
@likhinbopanna likhinbopanna changed the title feat: populate payment method details in payments response feat(revert): populate payment method details in payments response Sep 4, 2024
@likhinbopanna likhinbopanna changed the title feat(revert): populate payment method details in payments response feat: populate payment method details in payments response Sep 4, 2024
pixincreate added a commit that referenced this pull request Sep 5, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into cypress-v2
c16b53c 
* 'main' of github.com:juspay/hyperswitch:
  feat(customer_v2): Add customer V2 delete api (#5518)
  chore(version): 2024.09.05.0
  feat(user_roles): get user role details (#5777)
  feat(users): Add profile level invites (#5793)
  refactor(router): profile based routes for payouts (#5794)
  Feat(connector): [Fiuu] Add Card Flows (#5786)
  fix(cypress): fix fiservemea configs for cypress (#5772)
  fix(cypress): `api_key` check in cypress (#5787)
  feat(payment_methods_v2): Implemented Diesel and Domain models for v2 (#5700)
  fix(payout): query for getting a list of active payout IDs (#5771)
  refactor(router): remove admin v2 intermediate features (#5780)
  feat(revert): populate payment method details in payments response (#5785)
  chore(version): 2024.09.04.0
  fix(connector): skip 3DS in `network_transaction_id` flow for cybersource (#5781)
  refactor(euclid): check the authenticity of profile_id being used (#5647)
  feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication (#5729)
  fix(router): make customer details None in the `Psync` flow if the customer is deleted (#5732)
  feat(connector): [DEUTSCHE] Add template code (#5774)
  chore(version): 2024.09.03.1
  fix(router): send post message to window.parent instead of window.top in external 3ds flow (#5778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees
No one assigned
Labels
M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Payments and it's webhook response to contain non-card payment method details
4 participants
@lsampras @SanchithHegde @Narayanbhat166 @likhinbopanna