Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(router): profile based routes for payouts #5794

Merged
merged 26 commits into from
Sep 4, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Sep 4, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This change will ensure that the profile id being sent in params, belongs to the merchant using them.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Cannot be tested right now because currently we are not including profile_id in JWT.
Was able to compile the code.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 self-assigned this Sep 4, 2024
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners September 4, 2024 10:53
Copy link

semanticdiff-com bot commented Sep 4, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 26% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/routes/app.rs 3.39% smaller
✔️ crates/router/src/routes/routing.rs 46.35% smaller

@prajjwalkumar17 prajjwalkumar17 changed the title Refactor(router): routing dashboard related changes refactor(router): profile based routes for payouts Sep 4, 2024
crates/router/src/routes/app.rs Show resolved Hide resolved
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit eea5c4e Sep 4, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the refactor_routing_dashboard_related_changes branch September 4, 2024 15:16
pixincreate added a commit that referenced this pull request Sep 5, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(customer_v2): Add customer V2 delete api (#5518)
  chore(version): 2024.09.05.0
  feat(user_roles): get user role details (#5777)
  feat(users): Add profile level invites (#5793)
  refactor(router): profile based routes for payouts (#5794)
  Feat(connector): [Fiuu] Add Card Flows (#5786)
  fix(cypress): fix fiservemea configs for cypress (#5772)
  fix(cypress): `api_key` check in cypress (#5787)
  feat(payment_methods_v2): Implemented Diesel and Domain models for v2 (#5700)
  fix(payout): query for getting a list of active payout IDs (#5771)
  refactor(router): remove admin v2 intermediate features (#5780)
  feat(revert): populate payment method details in payments response (#5785)
  chore(version): 2024.09.04.0
  fix(connector): skip 3DS in `network_transaction_id` flow for cybersource (#5781)
  refactor(euclid): check the authenticity of profile_id being used (#5647)
  feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication (#5729)
  fix(router): make customer details None in the `Psync` flow if the customer is deleted (#5732)
  feat(connector): [DEUTSCHE] Add template code (#5774)
  chore(version): 2024.09.03.1
  fix(router): send post message to window.parent instead of window.top in external 3ds flow (#5778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: check the authenticity of profile_id being used for all the routing routes
6 participants