Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practices as-per "Open-source library guidance" #147

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Best practices as-per "Open-source library guidance" #147

merged 3 commits into from
Oct 26, 2018

Conversation

martincostello
Copy link
Member

Relates to #146.

Update some of the build properties as per "Open-source library guidance".

Changes

  1. Use NuGet profile name for the author.
  2. Use 64x64 logo image.
  3. Use commas to separate tags, not semi-colon.
  4. Strong-name the assembly.
  5. Fix the assembly version to the major version number with all other components as zero, not the package version number.

@martincostello
Freeze assembly version at major.0.0.0
c8fa634 
Freeze the assembly version at major.0.0.0 (i.e. 4.0.0.0) to reduce binding redirects when strong-named.
@martincostello
Update NuGet metadata
aad4a14 
Use NuGet profile name as author.
Use 64x64 package icon.
Use comma as tag delimiter.
@martincostello
Strong name the assembly
0d506a1 
Strong-name the library, as recommended: https://docs.microsoft.com/en-gb/dotnet/standard/library-guidance/strong-naming
@martincostello martincostello added this to the v4.0.0 milestone Oct 17, 2018
@martincostello martincostello requested a review from a team as a code owner October 17, 2018 11:02
@AnthonySteele
Copy link
Contributor

Strong-name the assembly
😱😱😱😱

@martincostello
Copy link
Member Author

I knew there'd be some level of "pitchforks" to that.

@martincostello martincostello mentioned this pull request Oct 17, 2018
Closed
@martincostello martincostello merged commit 1aefe93 into justeattakeaway:master Oct 26, 2018
@martincostello martincostello deleted the oss-library-guidance branch October 26, 2018 14:00
@martincostello martincostello mentioned this pull request Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonySteele AnthonySteele AnthonySteele approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@martincostello @AnthonySteele