Review compared to "Open-source library guidance"

[martincostello]

Before we release version 7.0.0, we should review the codebase with respect to the new "Open-source library guidance" documentation from Microsoft and determine what, if anything, we should do for JustSaying while we have the opportunity to make breaking changes.

The only obvious thing to consider that we don't currently do is strong-naming, which would allow the library to be consumed by applications/libraries that are/need strong-naming themselves.

Similar changes elsewhere on the same theme include:

• Best practices as-per "Open-source library guidance" JustEat.StatsD#147
• Best practices as-per "Open-source library guidance" httpclient-interception#56

[AnthonySteele]

I'm sure that we will debate strong naming.

[AnthonySteele]

We have agreed to allow strong naming.

[martincostello]

I'll look at doing a PR like the other two, unless someone else has a burning desire to do it.

[slang25]

On strong-naming, JustBehave is now signed, but structuremap isn't and it looks like there is no intention from them to do it, not sure the best way forwards with this 😕

[martincostello]

This might fit in with what I'm doing in #431, where I'm trying to make the DI more pluggable as a whole.

If that all works, we could replace StructureMap with something else that is, like the Microsoft one?

[slang25]

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[martincostello]

Re-reviewing this, it looks like the path forward is to move the tests for StructureMap into their own test assembly that doesn't need [assembly: InternalsVisibleTo("...")] and by necessity not strong-name JustSaying.Extensions.DependencyInjection.StructureMap. Then everything else should be sign-able and we can turn it on for the rest of the assemblies.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.