Test tidy up #577
Merged
Test tidy up #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
Oct 12, 2019
martincostello
commented
- Remove use of JustBehave from the integration tests to resolve Stop using JustBehave #380.
- Move the tests for StructureMap to their own project so that strong naming can be enabled.
- Enable strong naming to resolve Review compared to "Open-source library guidance" #402.
- Add MSBuild properties to make updating test dependency versions easier.
- Remove deleted items from Solution Items.
- Update Microsoft.SourceLink.GitHub and remove workaround for issue that should be fixed in that version.
Remove use of JustBehave from the integration tests.
Move the tests for StructureMap to their own project so that strong naming can be enabled. Add MSBuild properties to make updating test dependency versions easier. Remove deleted items from Solution Items.
Enable strong naming to resolve #402.
Fix broken namespace for attributes.
Update Microsoft.SourceLink.GitHub and remove workaround for issue that should be fixed in that version.
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 38.39% 38.39%
=======================================
Files 81 81
Lines 2930 2930
Branches 515 515
=======================================
Hits 1125 1125
Misses 1646 1646
Partials 159 159Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.