tagging and gauge operations

[gandarez]

• add support for tagging
• add support for gauge operations

Related to the issues 175 and 176.

[martincostello]

Thank you for you contribution @gandarez!

Tags are fairly self-explanatory, but can you explain a little more about what the gauge changes are for please?

[gandarez]

@martincostello thanks!

Fo all the comments you've done I already fixed them locally. There are only two left I'd need your assistance. The first is about the Shipped.txt and the other is how to I start integration tests in my machine.

I followed the documentation for gauges and implemented the concept of being able to change the sign for a gauge.
https://github.com/statsd/statsd/blob/master/docs/metric_types.md#gauges

[gandarez]

@martincostello please be adivised that I needed to add keyNameSanitize: false to avoid the backend to remove non-alpha like semicolon and equal. This kind of behaviour is not expected (and actually does not happen) on graphite.

https://graphite.readthedocs.io/en/latest/tags.html

[martincostello]

If this is needed to make tags work in general, we'd probably want this documented somewhere in the README.

Which reminds me, the README would also need to be updated to mention the tagging capabilities.

[martincostello]

Some guidance in the need to use keyNameSanitize if using tags would still be useful in the README.

[gandarez]

I think it should be always false since the tests cover tags and the StatsD server is mocked. In real life this flag does not exist, for instance when running on Graphite.

[martincostello]

It's not a mock, it's the real thing:

https://github.com/justeat/JustEat.StatsD/blob/34f5bf6bba124cd565c52b28e8679fbf941e1e6d/.travis.yml#L27-L29

[gandarez]

Any news here guys?

[jdiazmartin]

I'm looking forward to having a fine-grained metrics with tags. Is there an approximate date for version 5.0.0?

[martincostello]

I'm looking forward to having a fine-grained metrics with tags. Is there an approximate date for version 5.0.0?

Sorry, there's no planned release date at this time. This is something we'll pick up in more detail when we have the capacity for it.

[gandarez]

The PR will be clossed automatically soon.. no plans yet??

[martincostello]

Hi @gandarez - sorry for the lack of movement on this PR.

For tag support, we're going to take the change from #269 as it is implemented in a more extensible way for a range of different metrics providers.

Once that is merged, if you update this PR to just suggest changes to gauges, we can re-review this PR.

Thanks!

[martincostello]

#312 to add tagging support has been merged.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.