Tagging

[jgpayvision]

Support of tags or dimensions for the following providers:

• DataDog, Splunk and CloudWatch.
• InfluxDB.
• Librato.
• SignalFX.

It covers issue: #268

It contains a breaking change. The interface IStatsDPublisher has been modified to include the tags as Dictionary<string, string?>. The old methods of this interface have been included as extension methods at IStatsDPublisherExtensions.
Therefore:

• Implementations of IStatsDPublisher will be broken after the change.
• Former usage of IStatsDPublisher and StatsDPublisher will work as it was in the previous version.

Benchmarking

After the change

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.18363.1016 (1909/November2018Update/19H2)
Intel Core i7-7700HQ CPU 2.80GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.1.401
  [Host]     : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT
  DefaultJob : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT

Method	Mean	Error	StdDev	Gen 0	Gen 1	Gen 2	Allocated
BufferBased	248.0 ns	4.58 ns	4.29 ns	-	-	-	-
BufferBasedIgnoringTags	272.0 ns	3.61 ns	3.01 ns	-	-	-	-
BufferBasedIgnoringEmptyTags	256.3 ns	5.16 ns	5.94 ns	-	-	-	-
BufferBasedWithTagsFormatterAndNullTags	248.9 ns	4.86 ns	5.59 ns	-	-	-	-
BufferBasedWithTagsFormatter	661.2 ns	4.65 ns	4.35 ns	-	-	-	-
BufferBasedWithTagsFormatterAndEmptyTags	252.7 ns	3.36 ns	2.98 ns	-	-	-	-

Previous version

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.18363.1016 (1909/November2018Update/19H2)
Intel Core i7-7700HQ CPU 2.80GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.1.401
  [Host]     : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT
  DefaultJob : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT

Method	Mean	Error	StdDev	Gen 0	Gen 1	Gen 2	Allocated
BufferBased	226.8 ns	4.48 ns	3.97 ns	-	-	-	-

[martincostello]

Sorry for the delay in getting this reviewed.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@8999ed9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage        ?   94.45%           
=======================================
  Files           ?       27           
  Lines           ?      883           
  Branches        ?        0           
=======================================
  Hits            ?      834           
  Misses          ?       49           
  Partials        ?        0           

Flag	Coverage Δ
linux	93.65% <0.00%> (?)
macos	94.11% <0.00%> (?)
windows	93.99% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8999ed9...85d85cd. Read the comment docs.

[jgpayvision]

Sorry for the delay @martincostello.

All changes uploaded except the change from Dictionary to IDictionary.

[martincostello]

Thanks for your contribution @gomete - we'll need to make some changes internally to prepare other libraries that depend on JustEat.StatsD due to the breaking changes to the interface, so there'll be a bit of lag on getting this actually published to NuGet.org.

I'll try and publish a 5.0.0 beta to NuGet.org at some point this week.

[jgpayvision]

Sure! Thank you Martin! Kind regards, Jorge Gomez Rivas Software Engineer [cid:image001.png@01D7142F.21DE8A90] From: Martin Costello <notifications@github.com> Sent: Monday, March 8, 2021 3:23 PM To: justeat/JustEat.StatsD <JustEat.StatsD@noreply.github.com> Cc: Jorge Gomez Rivas <J.Gomez@payvision.com>; Author <author@noreply.github.com> Subject: Re: [justeat/JustEat.StatsD] Tagging (#312) Thanks for your contribution @gomete<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fgomete&data=04%7C01%7Cj.gomez%40payvision.com%7C618b64d648f84456670d08d8e23db0e1%7C37f9569137d54403bf0fd29bb85a2533%7C0%7C0%7C637508101894563193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GSkO%2FOOg%2Brq5SC3jnzjV5hwRaY%2FH%2B8e8%2FTqMbItFHRU%3D&reserved=0> - we'll need to make some changes internally to prepare other libraries that depend on JustEat.StatsD due to the breaking changes to the interface, so there'll be a bit of lag on getting this actually published to NuGet.org. I'll try and publish a 5.0.0 beta to NuGet.org at some point this week. - You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fjusteat%2FJustEat.StatsD%2Fpull%2F312%23issuecomment-792788119&data=04%7C01%7Cj.gomez%40payvision.com%7C618b64d648f84456670d08d8e23db0e1%7C37f9569137d54403bf0fd29bb85a2533%7C0%7C0%7C637508101894573148%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RFIpRPWpfpYoch4aHI1cRpdKSaxHhqFnzo1dt7TRzBk%3D&reserved=0>, or unsubscribe<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FASQL3UB5KK4F4BMX3TO42YDTCTMUTANCNFSM4WH26C3A&data=04%7C01%7Cj.gomez%40payvision.com%7C618b64d648f84456670d08d8e23db0e1%7C37f9569137d54403bf0fd29bb85a2533%7C0%7C0%7C637508101894573148%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=AQsKpWK0%2BqwEAgYY3doestxjNlWRVOtUPPZF2iUlC5A%3D&reserved=0>.