[WIP] Switch to coverlet #547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, that's the theory... |
maurofranchi
previously approved these changes
Jun 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 38.52% 38.41% -0.12%
==========================================
Files 78 89 +11
Lines 2754 3072 +318
Branches 487 427 -60
==========================================
+ Hits 1061 1180 +119
- Misses 1536 1855 +319
+ Partials 157 37 -120
Continue to review full report at Codecov.
|
|
For reasons I don't understand, some of the messages are being delivered more than once and breaking some of the test expectations 😕 |
|
All I can think of is the instrumentation slows down the tests and exposes some timing issues. |
Closed
Switch to coverlet for code coverage from OpenCover.
Fix code coverage failing because the tests weren't being put in the right output directory.
|
Bah - still timing issues in the tests making them fail. |
|
Replaced by #570. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to coverlet for code coverage from OpenCover.
coverlet is supported on non-Windows platforms, as well as being easier to configure.