-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Switch to coverlet #570
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to coverlet for code coverage from OpenCover.
Fix code coverage failing because the tests weren't being put in the right output directory.
Update to latest coverlet version.
Do not override CoverletOutput if OutputPath is not set.
Ignore coverage output files.
Try fixing slow Travis CI build by disabling the dotnet test progress indicator (untill `--logger:Console;noprogress=true` is supported or is automatically applied).
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 38.98% 39.77% +0.79%
==========================================
Files 78 90 +12
Lines 2783 3248 +465
Branches 488 445 -43
==========================================
+ Hits 1085 1292 +207
- Misses 1541 1913 +372
+ Partials 157 43 -114
Continue to review full report at Codecov.
|
Try and work out why the three same tests keep failing with coverlet added.
Disable code coverage when the integration tests are run with the emulator as for some reason it breaks everything.
Will come back around this this after the test tidy-up. |
Superseded by #578. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to coverlet for code coverage from OpenCover.
coverlet is supported on non-Windows platforms, as well as being easier to configure.
Replaces #547 as that appears to have become detached from my fork somehow.