Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch to coverlet #570

Closed
wants to merge 8 commits into from
Closed

[WIP] Switch to coverlet #570

wants to merge 8 commits into from

Conversation

martincostello
Copy link
Member

Switch to coverlet for code coverage from OpenCover.

coverlet is supported on non-Windows platforms, as well as being easier to configure.

Replaces #547 as that appears to have become detached from my fork somehow.

Switch to coverlet for code coverage from OpenCover.
Fix code coverage failing because the tests weren't being put in the right output directory.
Update to latest coverlet version.
Do not override CoverletOutput if OutputPath is not set.
Ignore coverage output files.
@martincostello martincostello added this to the v7.0.0 milestone Aug 26, 2019
@martincostello martincostello requested a review from a team as a code owner August 26, 2019 09:04
@ghost ghost requested a review from shaynevanasperen August 26, 2019 09:04
Try fixing slow Travis CI build by disabling the dotnet test progress indicator (untill `--logger:Console;noprogress=true` is supported or is automatically applied).
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #570 into master will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   38.98%   39.77%   +0.79%     
==========================================
  Files          78       90      +12     
  Lines        2783     3248     +465     
  Branches      488      445      -43     
==========================================
+ Hits         1085     1292     +207     
- Misses       1541     1913     +372     
+ Partials      157       43     -114
Impacted Files Coverage Δ
JustSaying/CreateMeABus.cs 33.33% <0%> (-16.67%) ⬇️
...stSaying/AwsTools/MessageHandling/SqsQueueByUrl.cs 33.33% <0%> (-3.04%) ⬇️
...aying/AwsTools/QueueCreation/AmazonQueueCreator.cs 13.04% <0%> (-1.25%) ⬇️
JustSaying/AwsTools/ErrorQueue.cs 12.5% <0%> (-0.84%) ⬇️
...tSaying/AwsTools/MessageHandling/SqsQueueByName.cs 5.26% <0%> (-0.49%) ⬇️
...g/Messaging/Interrogation/InterrogationResponse.cs 100% <0%> (ø) ⬆️
JustSaying/Fluent/AwsClientFactoryBuilder.cs 0% <0%> (ø) ⬆️
JustSaying/AwsTools/DefaultAwsClientFactory.cs 0% <0%> (ø) ⬆️
JustSaying/Fluent/PublicationsBuilder.cs 0% <0%> (ø) ⬆️
JustSaying/Fluent/SqsConfigurationBuilder.cs 0% <0%> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04bc31b...5fbfdfd. Read the comment docs.

Try and work out why the three same tests keep failing with coverlet added.
Disable code coverage when the integration tests are run with the emulator as for some reason it breaks everything.
@martincostello
Copy link
Member Author

Will come back around this this after the test tidy-up.

@martincostello martincostello deleted the coverlet branch October 12, 2019 22:14
@martincostello
Copy link
Member Author

Superseded by #578.

@martincostello martincostello removed this from the v7.0.0 milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant