Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build infrastructure updates #578

Merged
merged 20 commits into from
Oct 12, 2019
Merged

Build infrastructure updates #578

merged 20 commits into from
Oct 12, 2019

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Oct 12, 2019 •
edited
Loading

  • Build the whole solution, not just specific projects and TFMs on Linux/macOS.
  • Remove redundant package reference for AWSSDK.Core as its transient from the other two.
  • Use more recent minimum version for AWS SDK.
  • Update tests to latest AWS SDKs.
  • Use a build image for Visual Studio 2019 in AppVeyor.
  • Use newer format for NuGet Symbol packages.
  • Ignore code coverage artifacts.
  • Update various NuGet packages to their latest versions.
  • Fix or suppress new analyzer warnings.
  • Update to .NET Core 3.0 SDK.
  • Update tests and samples to .NET Core 3.0.
  • Delete or disable problematic tests (see Restore test coverage to previous levels #579).
  • Switch from OpenCover to coverlet.

@martincostello
Build whole solution
c39e614 
Build the whole solution, not just specific projects and TFMs on Linux/macOS.
@martincostello
Remove redundant reference
b58e310 
Remove redundant package reference for AWSSDK.Core as its transient from the other two.
@martincostello
Use more recent AWS SDKs
9b59bde 
Use more recent minimum version for AWS SDK.
Update tests to latest AWS SDKs.
@martincostello
Use Visual Studio 2019 image
328b94e 
Use a build image for Visual Studio 2019.
@martincostello
Use newer symbol package format
146f6db 
Use newer format for Symbol packages.
@martincostello
Use .NET Core 3.0 SDK
82d777b 
Use the .NET Core 3.0 SDK and target netcoreapp3.0 in the tests.
Use package icon file instead of package icon URL.
@martincostello
Update NuGet packages
847b57b 
Update various NuGet packages to their latest versions.
Fix analyzer warning.
@martincostello
Ignore code coverage files
13f09fc 
Ignore code coverage artifacts.
@martincostello
Supress analysis warning
0eb6333 
For now, suppress code analysis warning. Can fix at a later date.
@martincostello
Update sample to .NET Core 3.0
b3c8f3a 
Update sample to use .NET Core 3.0.
@martincostello martincostello added this to the v7.0.0 milestone Oct 12, 2019
@martincostello martincostello requested a review from a team as a code owner October 12, 2019 21:45
@ghost ghost requested a review from jaimalchohan October 12, 2019 21:45
maurofranchi
maurofranchi previously approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@maurofranchi maurofranchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@martincostello
Fix artifact filter
22d2cdd 
It's not a Regular Expression, so just use a wildcard.
@martincostello
Install 2.2 in Travis until MinVer supports 3.0
caf6016 
Install 2.2 in Travis CI until MinVer supports netcoreapp3.0.
@martincostello martincostello removed the request for review from jaimalchohan October 12, 2019 21:52
@martincostello
Fix code analysis warnings
8e6b9ae 
Dispose of IDisposable resources.
@martincostello
Disable parallel build in Travis
528432b 
Try and fix flaky build in Travis.
@martincostello
Use same options to test as build
92e5cda 
Specify the same output directory.
Explicitly build for Release.
Exit if tests fail.
@martincostello
Disable progress indicator
ffd3654 
Disable progress indicator to try and speed up Travis CI.
@martincostello
Remove old-style tests
f8d82bc 
Remove tests written in the "old" style that dont use the new fluent API.
@martincostello
Update Microsoft.Extensions.Logging
bb13aaa 
Update the version of Microsoft.Extensions.Logging in the test infrastructure.
@martincostello
Disable flaky tests
71625ee 
Disable flaky tests in Travis CI.
@martincostello
Switch to coverlet
3b3a17a 
Switch from OpenCover to coverlet for .NET Core 3.0 support and cross-platform code coverage.
@martincostello martincostello mentioned this pull request Oct 12, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #578 into master will increase coverage by 7.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   38.39%   45.55%   +7.16%     
==========================================
  Files          81       89       +8     
  Lines        2930     2331     -599     
  Branches      515        0     -515     
==========================================
- Hits         1125     1062      -63     
+ Misses       1646     1269     -377     
+ Partials      159        0     -159
Impacted Files Coverage Δ
...wsTools/MessageHandling/SqsNotificationListener.cs 74.19% <100%> (+12.93%) ⬆️
src/JustSaying/CreateMeABus.cs 33.33% <0%> (-16.67%) ⬇️
...stSaying/AwsTools/MessageHandling/SqsQueueByUrl.cs 33.33% <0%> (-3.04%) ⬇️
src/JustSaying/AwsTools/ErrorQueue.cs 12% <0%> (-1.34%) ⬇️
...aying/AwsTools/QueueCreation/AmazonQueueCreator.cs 13.51% <0%> (-0.78%) ⬇️
...rc/JustSaying/Fluent/QueueSubscriptionBuilder`1.cs 0% <0%> (ø) ⬆️
src/JustSaying/Extensions/TimespanExtensions.cs 0% <0%> (ø) ⬆️
...c/JustSaying/Fluent/SqsReadConfigurationBuilder.cs 0% <0%> (ø) ⬆️
...ools/QueueCreation/ConfigurationErrorsException.cs 25% <0%> (ø) ⬆️
...c/JustSaying/AwsTools/MessageHandling/SnsPolicy.cs 0% <0%> (ø) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4744d40...3b3a17a. Read the comment docs.

@martincostello martincostello merged commit abf7acb into justeattakeaway:master Oct 12, 2019
@martincostello martincostello deleted the Build-Infrastructure branch October 12, 2019 23:18
slang25
slang25 reviewed Oct 13, 2019
View reviewed changes
Directory.Build.props
@@ -43,10 +47,21 @@
<LangVersion>latest</LangVersion>
<RepositoryUrl>$(PackageProjectUrl).git</RepositoryUrl>
<SignAssembly>true</SignAssembly>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
Copy link
Member

@slang25 slang25 Oct 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've raised this before, but this is redundant for this package as symbols are embedded.

In this file there should only be SymbolPackageFormat or DebugType, one should go. I feel that embedded is appropriate, but would understand if you disagree.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to guard against an issue I had with publishing one of my own packages which stil used the old format where they get published from AppVeyor to a deprecated server which has since had expired TLS cert that made publishing fail: https://ci.appveyor.com/project/martincostello/sqllocaldb/builds/28012360#L181

Even if it's not in use, setting this means if we change in the future it's future-proofed.

@slang25
Copy link
Member

slang25 commented Oct 13, 2019

Very nice 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slang25 slang25 slang25 left review comments

@maurofranchi maurofranchi maurofranchi left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@martincostello @slang25 @maurofranchi