Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize + add f16 scalar implementations #44

Merged
merged 11 commits into from
Mar 26, 2023
Merged

feat: optimize + add f16 scalar implementations #44

merged 11 commits into from
Mar 26, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 24, 2023

  • add scalar f16 ignore nans
    • test scalar f16 implementation
  • add argmin & argmax variants for scalar f16 ignore nans
  • add argmin & argmax variants for scalar f16 return nans

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2023

CodSpeed Performance Report

Merging #44 opt_impl (dcc1db9) will not alter performances.

Summary

🔥 25 improvements
❌ 0 regressions
✅ 131 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main opt_impl Change
🔥 sse_u64_argminmax 1.8 ms 1.6 ms 13.84%
🔥 sse_u64_argmin 1.5 ms 1.3 ms 16.98%
🔥 avx2_u64_argminmax 868.5 µs 825.8 µs 4.92%
🔥 avx2_u64_argmin 740.2 µs 697.5 µs 5.77%
🔥 impl_u64_argminmax 868.7 µs 826 µs 4.91%
🔥 impl_u64_argmin 868.7 µs 826 µs 4.91%
🔥 impl_u64_argmax 868.7 µs 826 µs 4.91%
🔥 sse_i64_argminmax 1.8 ms 1.5 ms 14.51%
🔥 sse_i64_argmin 1.4 ms 1.2 ms 17.99%
🔥 avx2_i64_argminmax 868.4 µs 825.7 µs 4.92%
🔥 avx2_i64_argmin 740.2 µs 697.5 µs 5.77%
🔥 impl_i64_argminmax 868.7 µs 826 µs 4.92%
🔥 impl_i64_argmin 868.7 µs 826 µs 4.92%
🔥 impl_i64_argmax 868.7 µs 826 µs 4.92%
🔥 scalar_f16_argmin_rn 3.3 ms 3 ms 10.24%
🔥 scalar_f16_argmax_rn 3.3 ms 3 ms 10.24%
🔥 sse_f64_argminmax_rn 2.3 ms 2 ms 14.72%
🔥 sse_f64_argmin_rn 2.3 ms 2 ms 14.72%
🔥 sse_f64_argmax_rn 2.3 ms 2 ms 14.72%
🔥 avx2_f64_argminmax_rn 1.1 ms 1 ms 3.95%
🔥 avx2_f64_argmin_rn 1.1 ms 1 ms 3.95%
🔥 avx2_f64_argmax_rn 1.1 ms 1 ms 3.95%
🔥 impl_f64_argminmax_rn 1.1 ms 1 ms 3.95%
🔥 impl_f64_argmin_rn 1.1 ms 1 ms 3.95%
🔥 impl_f64_argmax_rn 1.1 ms 1 ms 3.95%

@jvdd jvdd changed the title perf: optimize scalar implementations feat: optimize + add f16 scalar implementations Mar 26, 2023
@jvdd jvdd merged commit 7640b73 into main Mar 26, 2023
@jvdd jvdd deleted the opt_impl branch March 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant