Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add f16 simd support for ignore nan #46

Merged
merged 11 commits into from
Mar 29, 2023
Merged

🎉 add f16 simd support for ignore nan #46

merged 11 commits into from
Mar 29, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 28, 2023

Is 10x faster than already optimized scalar implementation (using ord_transform - see #44 )

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2023

CodSpeed Performance Report

Merging #46 f16_ignore_nan (324d335) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 156 untouched benchmarks

🆕 12 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main f16_ignore_nan Change
🆕 scalar_f16_argminmax_in N/A 4.2 ms N/A
🆕 scalar_f16_argmin_in N/A 2.8 ms N/A
🆕 scalar_f16_argmax_in N/A 2.8 ms N/A
🆕 sse_f16_argminmax_in N/A 603.2 µs N/A
🆕 sse_f16_argmin_in N/A 495.8 µs N/A
🆕 sse_f16_argmax_in N/A 495.8 µs N/A
🆕 avx2_f16_argminmax_in N/A 294.1 µs N/A
🆕 avx2_f16_argmin_in N/A 250.6 µs N/A
🆕 avx2_f16_argmax_in N/A 250.7 µs N/A
🆕 impl_f16_argminmax_in N/A 294.4 µs N/A
🆕 impl_f16_argmin_in N/A 250.8 µs N/A
🆕 impl_f16_argmax_in N/A 250.9 µs N/A

@jvdd jvdd merged commit dc6548a into main Mar 29, 2023
@jvdd jvdd deleted the f16_ignore_nan branch April 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant