Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go 1.18.1 #1666

Merged
merged 1 commit into from
May 6, 2022
Merged

Bump go 1.18.1 #1666

merged 1 commit into from
May 6, 2022

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Apr 28, 2022

Description

Kubernetes 1.24 switched to go 1.18.1 as well.

See #1663

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 requested a review from a team as a code owner April 28, 2022 18:44
@twz123 twz123 requested review from jnummelin and trawler April 28, 2022 18:44
@twz123 twz123 added the enhancement New feature or request label Apr 28, 2022
@twz123
Copy link
Member Author

twz123 commented Apr 28, 2022

Corresponding Kubernetes PR: kubernetes/kubernetes#109461

@twz123
Copy link
Member Author

twz123 commented Apr 28, 2022

And its minimum go version requirement: kubernetes/kubernetes#109484

@twz123 twz123 force-pushed the bump-go-1.18.1 branch from f15a61e to c2126b1 Compare May 2, 2022 11:21
@@ -1,21 +1,233 @@
module cideps
module ci-deps
Copy link
Member Author

@twz123 twz123 May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go for #1670, then those files will become supefluous.

@twz123 twz123 force-pushed the bump-go-1.18.1 branch from c2126b1 to 99feb40 Compare May 2, 2022 16:32
Kubernetes 1.24 switched to go 1.18.1 as well.

* Remove as many hard-coded go versions as possible
* Also regenerate go.mod/go.sum for CI dependencies
* Add empty go.mod to ignore build directory from go tools
  See golang/go#30058 (comment)
* Add missing dependencies to Makefile targets
* Set git config advice.detachedHead=false for embedded binaries
  So that there's less log spam
* Change go get to go install for Konnectivity

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the bump-go-1.18.1 branch from 99feb40 to de6cecb Compare May 6, 2022 07:09
@twz123 twz123 merged commit e3c84cf into k0sproject:main May 6, 2022
@twz123 twz123 deleted the bump-go-1.18.1 branch May 6, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants