Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GO] Update Go to 1.18.1 #109461

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[GO] Update Go to 1.18.1 #109461

merged 1 commit into from
Apr 13, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 13, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update Go to 1.18.1

Which issue(s) this PR fixes:

xref kubernetes/release#2499

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.18.1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @xmudrii @saschagrunert @palnabarun @puerco @justaugustus @dims
cc @kubernetes/release-engineering

@cpanato
Update Go to 1.18.1
2e9d10e 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 13, 2022
@cpanato cpanato mentioned this pull request Apr 13, 2022
Closed
17 tasks
@puerco
Copy link
Member

puerco commented Apr 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@puerco
Copy link
Member

puerco commented Apr 13, 2022

/lgtm

@dims
Copy link
Member

dims commented Apr 13, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@cpanato
Copy link
Member Author

cpanato commented Apr 13, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 75e49ec into kubernetes:master Apr 13, 2022
@cpanato cpanato deleted the go118 branch April 13, 2022 16:28
@cpanato cpanato mentioned this pull request Apr 13, 2022
Merged
@pacoxu pacoxu mentioned this pull request Apr 14, 2022
Closed
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
Open
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Open
@twz123 twz123 mentioned this pull request Apr 28, 2022
Merged
16 tasks
MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request May 10, 2022
@MaciekPytel
Update to go 1.18.1
62c5fbe 
This follows go update in kubernetes: kubernetes/kubernetes#109461
@mansikulkarni96 mansikulkarni96 mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus justaugustus approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @puerco @dims @k8s-ci-robot @justaugustus @saschagrunert