Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating golang image to 1.18.1 #29027

Merged
merged 1 commit into from
May 31, 2022

Conversation

mansikulkarni96
Copy link
Member

@mansikulkarni96 mansikulkarni96 commented May 31, 2022

This PR updates the golang image to vesrion 1.18.1.
Building 1.24 kube-proxy Windows platform binaries requires the minimum version to be 1.18.1.
Ref upstream PR: kubernetes/kubernetes#109461
Issue: kubernetes/release#2499

@openshift-ci openshift-ci bot requested review from bear-redhat and jmguzik May 31, 2022 15:59
@selansen
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
This commit updates the golang image to
vesrion 1.18.1. Building 1.24 kube-proxy
Windows platform binaries requires the
minimum version to be 1.18.1.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@selansen
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, mansikulkarni96, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b0683d0 into openshift:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants