Give external-dns assume role capabilities with route53 provider (helm) #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasbokreta
requested review from
donovanmuller,
k0da,
kuritka,
somaritane,
ytsarev and
jkremser
as code owners
Allow accessing AWS Route53 hosted zones handled in different AWS accounts thru assume role Signed-off-by: eliasbokreta <elias.bokreta@gmail.com>
The disabled option of the irsaRole key was not working due to json schema validation regex. Modified the expected value to `null`. Signed-off-by: eliasbokreta <elias.bokreta@gmail.com>
eliasbokreta
force-pushed
the
chore/allow-aws-assume-role
branch
from
bbabfec
to
26ab539
Compare
|
You have successfully added a new terrascan configuration |
ytsarev
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to add the capability for
external-dnsto assume role, usingroute53provider when the hosted zones are handled in a different AWS account by adding--aws-assume-roleargument (see this external-dns PR).The change was successfully deployed on our clusters and is now, able to access the given hosted zone.
Besides this change, I've also fixed
route53.irsaRolewhen disabled. The json schema validation regex was not allowing any other value than a valid ARN string.If anything is unclear/missing please let me know 🙂