Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Allow to assume another role #524

Merged
merged 3 commits into from
Apr 18, 2018
Merged

AWS: Allow to assume another role #524

merged 3 commits into from
Apr 18, 2018

Conversation

linki
Copy link
Member

@linki linki commented Apr 12, 2018 •
edited
Loading

This allows to specify a role in the same or another account to assume. It allows ExternalDNS to manage hosted zones in another account.

Use it like so:

$ external-dns --provider=aws --aws-assume-role=arn:aws:iam::123455567:role/app-external-dns

where 123455567 is your AWS account number and app-external-dns the role in that account.

Note, you have to setup the correct sts:AssumeRole permission on the client and the corresponding Trust Relationship on the target role.

Fixes #475

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2018
@linki
Copy link
Member Author

linki commented Apr 12, 2018

Note: The credentials might expire after an hour or so. Let's check 😅

njuettner
njuettner requested changes Apr 13, 2018
View reviewed changes
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2018
@njuettner
Copy link
Member

👍

@njuettner njuettner merged commit 8819ed6 into kubernetes-sigs:master Apr 18, 2018
@jdeprin jdeprin mentioned this pull request Aug 10, 2018
Closed
@linki linki deleted the assume-role branch January 23, 2019 13:48
@enis enis mentioned this pull request Mar 13, 2019
Merged
3 tasks
@aidan-melen aidan-melen mentioned this pull request Jul 20, 2020
Closed
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
@ahmetb
site: robots.txt (kubernetes-sigs#524)
2045542 
Prevent Netlify preview environments from being indexed by search bots.

If HUGO_ENV!=production, we return Disallow:/

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@eliasbokreta eliasbokreta mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. provider/aws size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linki @njuettner @k8s-ci-robot