Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Ability to assume a role in secondary account was not included in aws-sd #670

Closed
jdeprin opened this issue Aug 10, 2018 · 2 comments
Closed
Labels
kind/support Categorizes issue or PR as a support question. provider/aws

Comments

@jdeprin
Copy link

jdeprin commented Aug 10, 2018

The ability to assume an IAM role in a seconday account was added in: #524. This however only added it to the aws provider but left it out of the aws-sd provider.

Can this functionality be moved over so that both R53 and service discovery can be accessed through an assumed role?

https://github.com/kubernetes-incubator/external-dns/blob/master/provider/aws.go#L111
https://github.com/kubernetes-incubator/external-dns/blob/master/provider/aws_sd.go#L72

@njuettner njuettner added kind/support Categorizes issue or PR as a support question. provider/aws labels Aug 13, 2018
@njuettner
Copy link
Member

@vanekjar What do you think? Can this be addressed?

@goatsthatcode
Copy link
Contributor

I just submitted a PR to address this, I have signed the CLA agreement but it does not seem to have registered yet in their system. Please let me know if there is anything else I can do to expedite this.

lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question. provider/aws
Projects
None yet
Development

No branches or pull requests

3 participants