Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mattermost sink #303

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat: add mattermost sink #303

merged 4 commits into from
Jan 11, 2024

Conversation

tozastation
Copy link
Contributor

@tozastation tozastation commented Jan 1, 2024

Closes #300

📑 Description

  1. added mattermost sink
  • support mattermost incoming webhook
  1. added parameter on sink (K8sGPT API)
  • Channel (Mattermost Optional Param)
  • Username (Mattermost Optional Param)
  • IconURL (Mattermost Optional Param)
  • Mattermost Docs

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

  1. Confirmed that no value is entered in the notification content when ai is set to enable: false.
    (current Slack notifications may be notified with no value as well.)
Screenshot 2024-01-01 at 8 05 19 PM

Change to -> I tried to load error text when ai is enable: false.

Screenshot 2024-01-01 at 8 05 08 PM
  1. E2E Test Contents
  • test assets is here
    • deploy mattermost server
    • applying resources detected in k8sgpt
    • confirmation of incoming notifications

ai.enable: false pattern

Screenshot 2024-01-01 at 8 05 08 PM

ai.enable: true pattern
Screenshot 2024-01-01 at 9 17 42 PM

Signed-off-by: tozastation <tozastation@gmail.com>
@tozastation tozastation requested review from a team as code owners January 1, 2024 12:18
@tozastation
Copy link
Contributor Author

@AlexsJones
PR created. Please review when you are available...!

@tozastation tozastation changed the title [Draft] feat: add mattermost sink feat: add mattermost sink Jan 1, 2024
AlexsJones
AlexsJones previously approved these changes Jan 4, 2024
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good contribution; I was going to mention that having the channel/icon/url might be confusing to Slack sink users, but I think it's okay.

Can I ask you please to contribute to the docs on this?

https://github.com/k8sgpt-ai/docs ?

arbreezy
arbreezy previously approved these changes Jan 4, 2024
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm !
As Alex said, let's add docs so people know how to use it
A quick note: it's totally valid to send a report when we don't enable ai, cause message is still helpful from k8sgpt analysis. In theory we shouldn't see empty result CRs being created 🤔

@arbreezy
Copy link
Member

arbreezy commented Jan 4, 2024

@tozastation you also have to manually update the helm chart crd template

@tozastation
Copy link
Contributor Author

@AlexsJones @arbreezy
Thanks for the review !!
I will respond to it !!

Signed-off-by: tozastation <tozastation@gmail.com>
@tozastation tozastation dismissed stale reviews from arbreezy and AlexsJones via d586c9f January 9, 2024 23:55
@tozastation
Copy link
Contributor Author

@AlexsJones

I added an explanation to README.md of k8sgpt-operator. Please check it...!
Which file should I put in k8sgpt-ai/docs?

@AlexsJones AlexsJones merged commit c6ff954 into k8sgpt-ai:main Jan 11, 2024
5 checks passed
phillipahereza pushed a commit to phillipahereza/k8sgpt-operator that referenced this pull request Jan 11, 2024
* feat: add mattermost sink

Signed-off-by: tozastation <tozastation@gmail.com>

* feat: add mattermost sink on README.md

Signed-off-by: tozastation <tozastation@gmail.com>

---------

Signed-off-by: tozastation <tozastation@gmail.com>
Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
JuHyung-Son pushed a commit to JuHyung-Son/k8sgpt-operator that referenced this pull request Jan 16, 2024
* feat: add mattermost sink

Signed-off-by: tozastation <tozastation@gmail.com>

* feat: add mattermost sink on README.md

Signed-off-by: tozastation <tozastation@gmail.com>

---------

Signed-off-by: tozastation <tozastation@gmail.com>
Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: JuHyung-Son <sonju0427@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add Mattermost Sink
3 participants