-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mattermost sink #303
Conversation
Signed-off-by: tozastation <tozastation@gmail.com>
@AlexsJones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, good contribution; I was going to mention that having the channel/icon/url might be confusing to Slack sink users, but I think it's okay.
Can I ask you please to contribute to the docs on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm !
As Alex said, let's add docs so people know how to use it
A quick note: it's totally valid to send a report when we don't enable ai, cause message is still helpful from k8sgpt analysis. In theory we shouldn't see empty result CRs being created 🤔
@tozastation you also have to manually update the helm chart crd template |
@AlexsJones @arbreezy |
Signed-off-by: tozastation <tozastation@gmail.com>
I added an explanation to README.md of k8sgpt-operator. Please check it...! |
* feat: add mattermost sink Signed-off-by: tozastation <tozastation@gmail.com> * feat: add mattermost sink on README.md Signed-off-by: tozastation <tozastation@gmail.com> --------- Signed-off-by: tozastation <tozastation@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
* feat: add mattermost sink Signed-off-by: tozastation <tozastation@gmail.com> * feat: add mattermost sink on README.md Signed-off-by: tozastation <tozastation@gmail.com> --------- Signed-off-by: tozastation <tozastation@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: JuHyung-Son <sonju0427@gmail.com>
Closes #300
📑 Description
Channel
(Mattermost Optional Param)Username
(Mattermost Optional Param)IconURL
(Mattermost Optional Param)✅ Checks
ℹ Additional Information
enable: false
.(current Slack notifications may be notified with no value as well.)
Change to -> I tried to load error text when ai is enable: false.
ai.enable: false pattern
ai.enable: true pattern
![Screenshot 2024-01-01 at 9 17 42 PM](https://private-user-images.githubusercontent.com/27955845/293585873-a6c33d71-11ea-4499-9b11-d8c45b847a12.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMTg3MzYsIm5iZiI6MTcyMTExODQzNiwicGF0aCI6Ii8yNzk1NTg0NS8yOTM1ODU4NzMtYTZjMzNkNzEtMTFlYS00NDk5LTliMTEtZDhjNDViODQ3YTEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDA4MjcxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI0YTM4MDljNzYwYjhmNmExNGE4OGM4ZTA4ZGZjYTg1MDQ3N2Y4NjUzNTU0MmM1MzA1YThjOGNiZDg3OGNiYTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.jtRlLuj1ueEk4zZG9GSFT0gEeWWlcTXwP5EnitPSQqk)